r25047 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25046‎ | r25047 | r25048 >
Date:13:22, 22 August 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 11023) Don't register Special:Upload as a special page when uploads are disabled
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -84,7 +84,6 @@
8585 'Watchlist' => array( 'SpecialPage', 'Watchlist' ),
8686
8787 'Recentchanges' => array( 'IncludableSpecialPage', 'Recentchanges' ),
88 - 'Upload' => array( 'SpecialPage', 'Upload' ),
8988 'Imagelist' => array( 'SpecialPage', 'Imagelist' ),
9089 'Newimages' => array( 'IncludableSpecialPage', 'Newimages' ),
9190 'Listusers' => array( 'SpecialPage', 'Listusers' ),
@@ -160,7 +159,7 @@
161160 */
162161 static function initList() {
163162 global $wgSpecialPages;
164 - global $wgDisableCounters, $wgDisableInternalSearch, $wgEmailAuthentication;
 163+ global $wgDisableCounters, $wgDisableInternalSearch, $wgEmailAuthentication, $wgEnableUploads;
165164
166165 if ( self::$mListInitialised ) {
167166 return;
@@ -182,6 +181,10 @@
183182 self::$mList['Confirmemail'] = 'EmailConfirmation';
184183 }
185184
 185+ if( $wgEnableUploads ) {
 186+ self::$mList['Upload'] = array( 'SpecialPage', 'Upload' );
 187+ }
 188+
186189 # Add extension special pages
187190 self::$mList = array_merge( self::$mList, $wgSpecialPages );
188191
Index: trunk/phase3/RELEASE-NOTES
@@ -185,6 +185,8 @@
186186 * (bug 9002) Provide a "view/restore deleted edits" link on Special:Upload
187187 when a destination filename is provided that corresponds with previous
188188 deleted files
 189+* (bug 11023) Don't register Special:Upload as a special page when uploads are
 190+ disabled
189191
190192 == Bugfixes since 1.10 ==
191193

Follow-up revisions

RevisionCommit summaryAuthorDate
r25058Revert r25047 -- produces confusing, useless behavior when going to Special:U...brion16:25, 22 August 2007
r25109Merged revisions 25016-25108 via svnmerge from...david07:30, 24 August 2007

Status & tagging log