r25058 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25057‎ | r25058 | r25059 >
Date:16:25, 22 August 2007
Author:brion
Status:old
Tags:
Comment:
Revert r25047 -- produces confusing, useless behavior when going to Special:Upload instead of displaying the useful message that you have to enable uploads.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -84,6 +84,7 @@
8585 'Watchlist' => array( 'SpecialPage', 'Watchlist' ),
8686
8787 'Recentchanges' => array( 'IncludableSpecialPage', 'Recentchanges' ),
 88+ 'Upload' => array( 'SpecialPage', 'Upload' ),
8889 'Imagelist' => array( 'SpecialPage', 'Imagelist' ),
8990 'Newimages' => array( 'IncludableSpecialPage', 'Newimages' ),
9091 'Listusers' => array( 'SpecialPage', 'Listusers' ),
@@ -159,7 +160,7 @@
160161 */
161162 static function initList() {
162163 global $wgSpecialPages;
163 - global $wgDisableCounters, $wgDisableInternalSearch, $wgEmailAuthentication, $wgEnableUploads;
 164+ global $wgDisableCounters, $wgDisableInternalSearch, $wgEmailAuthentication;
164165
165166 if ( self::$mListInitialised ) {
166167 return;
@@ -181,10 +182,6 @@
182183 self::$mList['Confirmemail'] = 'EmailConfirmation';
183184 }
184185
185 - if( $wgEnableUploads ) {
186 - self::$mList['Upload'] = array( 'SpecialPage', 'Upload' );
187 - }
188 -
189186 # Add extension special pages
190187 self::$mList = array_merge( self::$mList, $wgSpecialPages );
191188
Index: trunk/phase3/RELEASE-NOTES
@@ -185,8 +185,6 @@
186186 * (bug 9002) Provide a "view/restore deleted edits" link on Special:Upload
187187 when a destination filename is provided that corresponds with previous
188188 deleted files
189 -* (bug 11023) Don't register Special:Upload as a special page when uploads are
190 - disabled
191189 * Make the "invalid special page" message clearer
192190
193191 == Bugfixes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r25109Merged revisions 25016-25108 via svnmerge from...david07:30, 24 August 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25047(bug 11023) Don't register Special:Upload as a special page when uploads are ...robchurch13:22, 22 August 2007

Status & tagging log