r24829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24828‎ | r24829 | r24830 >
Date:17:54, 15 August 2007
Author:aaron
Status:old
Tags:
Comment:
Use subtitles to make this consistent with delete/protect and the like
Modified paths:
  • /trunk/phase3/includes/FileRevertForm.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1492,7 +1492,8 @@
14931493 'imagelist_search_for' => 'Search for image name:',
14941494
14951495 # File reversion
1496 -'filerevert' => 'Revert $1',
 1496+'filerevert' => 'Confirm file revert',
 1497+'filerevertsub' => '(Reverting "$1" to previous revision)',
14971498 'filerevert-legend' => 'Revert file',
14981499 'filerevert-intro' => "<span class=\"plainlinks\">You are reverting '''[[Media:$1|$1]]''' to the [$4 version as of $2, $3].</span>",
14991500 'filerevert-comment' => 'Comment:',
Index: trunk/phase3/includes/FileRevertForm.php
@@ -133,7 +133,8 @@
134134 */
135135 private function setHeaders() {
136136 global $wgOut;
137 - $wgOut->setPageTitle( wfMsg( 'filerevert', $this->title->getText() ) );
 137+ $wgOut->setPageTitle( wfMsg( 'filerevert' ) );
 138+ $wgOut->setSubtitle( wfMsg( 'filerevertsub', $this->title->getPrefixedText() ) );
138139 $wgOut->setRobotPolicy( 'noindex,nofollow' );
139140 }
140141

Follow-up revisions

RevisionCommit summaryAuthorDate
r24832Reverting r24829; using subtitles leads to an unclear UI, and is a practice t...robchurch19:15, 15 August 2007
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007

Status & tagging log