r24832 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24831‎ | r24832 | r24833 >
Date:19:15, 15 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Reverting r24829; using subtitles leads to an unclear UI, and is a practice that ought to be deprecated
Modified paths:
  • /trunk/phase3/includes/FileRevertForm.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileRevertForm.php
@@ -133,8 +133,7 @@
134134 */
135135 private function setHeaders() {
136136 global $wgOut;
137 - $wgOut->setPageTitle( wfMsg( 'filerevert' ) );
138 - $wgOut->setSubtitle( wfMsg( 'filerevertsub', $this->title->getPrefixedText() ) );
 137+ $wgOut->setPageTitle( wfMsg( 'filerevert', $this->title->getText() ) );
139138 $wgOut->setRobotPolicy( 'noindex,nofollow' );
140139 }
141140
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1492,8 +1492,7 @@
14931493 'imagelist_search_for' => 'Search for image name:',
14941494
14951495 # File reversion
1496 -'filerevert' => 'Confirm file revert',
1497 -'filerevertsub' => '(Reverting "$1" to previous revision)',
 1496+'filerevert' => 'Revert $1',
14981497 'filerevert-legend' => 'Revert file',
14991498 'filerevert-intro' => "<span class=\"plainlinks\">You are reverting '''[[Media:$1|$1]]''' to the [$4 version as of $2, $3].</span>",
15001499 'filerevert-comment' => 'Comment:',

Follow-up revisions

RevisionCommit summaryAuthorDate
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r24829Use subtitles to make this consistent with delete/protect and the likeaaron17:54, 15 August 2007

Status & tagging log