r24168 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24167‎ | r24168 | r24169 >
Date:15:51, 16 July 2007
Author:simetrical
Status:old
Tags:
Comment:
* RELEASE-NOTES from last commit
* (bug 1629) Stop section edit links from being shoved down by other floats, using a one-line CSS fix that should have no other effects
* Move some editsection rules into shared.css (some more header stuff is still left scattered around and should probably be centralized before that document structure is mercilessly purged as evil and un-semantic)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
@@ -52,8 +52,6 @@
5353 }
5454 .editsection {
5555 font-weight: normal;
56 - float: right;
57 - margin-left: 5px;
5856 }
5957 h1 { font-size: 188%; }
6058 h1 .editsection { font-size: 53.2%; }
Index: trunk/phase3/skins/monobook/main.css
@@ -137,11 +137,6 @@
138138 h6 { font-size: 80%; }
139139 h6 .editsection { font-size: 125%; font-weight: normal; }
140140
141 -.editsection {
142 - float: right;
143 - margin-left: 5px;
144 -}
145 -
146141 ul {
147142 line-height: 1.5em;
148143 list-style-type: square;
Index: trunk/phase3/skins/common/oldshared.css
@@ -19,8 +19,6 @@
2020 /* Make edit sections (which are inside h# tags) normal-sized */
2121 .editsection {
2222 font-weight: normal;
23 - float: right;
24 - margin-left: 5px;
2523 }
2624 h1 .editsection { font-size: 50% }
2725 h2 .editsection { font-size: 66.7% }
Index: trunk/phase3/skins/common/shared.css
@@ -22,4 +22,14 @@
2323 background-color: #fcfcfc;
2424 }
2525
26 -
 26+/* Edit section links */
 27+.editsection {
 28+ float: right;
 29+ margin-left: 5px;
 30+}
 31+h1, h2, h3, h4, h5, h6 {
 32+ /* CSS voodoo magic: floats can interfere with each other unless we create
 33+ a new block formatting context for them to live in. The most harmless
 34+ way to do that in CSS2.1 is to use overflow: hidden. */
 35+ overflow: hidden;
 36+}
Index: trunk/phase3/skins/simple/main.css
@@ -10,12 +10,9 @@
1111
1212 /* Now the custom parts */
1313
14 -/* Make edit sections (which are inside h# tags) normal-sized
15 - and otherwise format */
 14+/* Make edit sections (which are inside h# tags) normal-sized */
1615 .editsection {
1716 font-weight: normal;
18 - float: right;
19 - margin-left: 5px;
2017 }
2118 h1 .editsection { font-size: 50% }
2219 h2 .editsection { font-size: 66.7% }
Index: trunk/phase3/RELEASE-NOTES
@@ -143,6 +143,11 @@
144144 * Introduced 'ContributionsToolLinks' hook; see docs/hooks.txt for more
145145 information
146146 * Add a message if category is empty
 147+* Add CSS compatibility for Opera 9.5
 148+* Remove largely untested handheld stylesheet, which was causing more trouble
 149+ than good. Proper handheld support will be added at a future date. For now,
 150+ display should be acceptable either with CSS turned off or when using a so-
 151+ phisticated handheld browser.
147152
148153 == Bugfixes since 1.10 ==
149154
@@ -300,6 +305,7 @@
301306 * (bug 10560) Adding a space between category letter heading and "continues"
302307 * Don't allow retrieving non-JavaScript/CSS pages with "text/css" or "text/javascript"
303308 MIME types
 309+* (bug 1629) Stop section edit links from being shoved down by other floats
304310
305311 == API changes since 1.10 ==
306312

Follow-up revisions

RevisionCommit summaryAuthorDate
r24215Merged revisions 24095-24212 via svnmerge from...david21:19, 17 July 2007
r24253Partial revert of r24168: it *does* have other effects, it breaks headings on...rotem20:43, 18 July 2007
r24276Merged revisions 24213-24275 via svnmerge from...david20:20, 19 July 2007

Status & tagging log