r24017 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r24016‎ | r24017 | r24018 >
Date:19:21, 11 July 2007
Author:brion
Status:old
Tags:
Comment:
Fix regression from r23575 -- wl_notificationtimestamp didn't get updated anymore on update notification, leading to duplicate mails being sent out.
Doing a WHERE on x=NULL doesn't work; need to do 'x IS NULL' here.
Perhaps we should make the DB functions smarter to handle that case to do what we'd expect it to do (as we do turning arrays into 'IN (...)') but this'll fix it for now.
Modified paths:
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
——@@ -376,7 +376,7 @@
377377 ), array( /* WHERE */
378378 'wl_title' => $title->getDBkey(),
379379 'wl_namespace' => $title->getNamespace(),
380 - 'wl_notificationtimestamp' => NULL
 380+ 'wl_notificationtimestamp IS NULL'
381381 ), 'UserMailer::NotifyOnChange'
382382 );
383383 # FIXME what do we do on failure ?

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23575*Mark all versions newer than the time of the latest revision viewed as "upda...aaron01:03, 30 June 2007

Status & tagging log