r24016 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24015‎ | r24016 | r24017 >
Date:17:45, 11 July 2007
Author:brion
Status:old
Tags:
Comment:
Don't spew () when tools group is empty (as on last line where there can be no undo link)
Modified paths:
  • /trunk/phase3/includes/PageHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PageHistory.php
@@ -262,7 +262,9 @@
263263 $tools[] = "<span class=\"mw-history-undo\">{$undolink}</span>";
264264 }
265265
266 - $s .= ' (' . implode( ' | ', $tools ) . ')';
 266+ if( $tools ) {
 267+ $s .= ' (' . implode( ' | ', $tools ) . ')';
 268+ }
267269
268270 wfRunHooks( 'PageHistoryLineEnding', array( &$row , &$s ) );
269271

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log