r23541 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23540‎ | r23541 | r23542 >
Date:06:01, 29 June 2007
Author:simetrical
Status:old
Tags:
Comment:
(bug 10184) Site CSS/JS should be included after that added dynamically (e.g. by extensions). Shouldn't break anything, I think. MediaWiki:GeSHi.css could be removed now.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -73,6 +73,10 @@
7474
7575 <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath' ) ?>/common/wikibits.js?<?php echo $GLOBALS['wgStyleVersion'] ?>"><!-- wikibits js --></script>
7676 <?php if($this->data['jsvarurl' ]) { ?>
 77+
 78+ <!-- Head Scripts -->
 79+<?php $this->html('headscripts') ?>
 80+
7781 <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('jsvarurl' ) ?>"><!-- site js --></script>
7882 <?php } ?>
7983 <?php if($this->data['pagecss' ]) { ?>
@@ -88,8 +92,6 @@
8993 <script type="<?php $this->text('jsmimetype') ?>"><?php $this->html('userjsprev') ?></script>
9094 <?php }
9195 if($this->data['trackbackhtml']) print $this->data['trackbackhtml']; ?>
92 - <!-- Head Scripts -->
93 -<?php $this->html('headscripts') ?>
9496 </head>
9597 <body <?php if($this->data['body_ondblclick']) { ?>ondblclick="<?php $this->text('body_ondblclick') ?>"<?php } ?>
9698 <?php if($this->data['body_onload' ]) { ?>onload="<?php $this->text('body_onload') ?>"<?php } ?>
Index: trunk/phase3/RELEASE-NOTES
@@ -240,6 +240,8 @@
241241 equivalent to a whitelisted title
242242 * Don't use garbled parser cache output when viewing custom CSS or JavaScript
243243 pages
 244+* (bug 10184) Site CSS/JS should be included after that added dynamically (e.g.
 245+ by extensions)
244246
245247 == API changes since 1.10 ==
246248

Follow-up revisions

RevisionCommit summaryAuthorDate
r23556Revert r23541, breaks AJAX watch and god knows what elsebrion14:12, 29 June 2007
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007
r28455* (bug 10184) Extensions' stylesheets and scripts should be loaded before use...simetrical23:35, 13 December 2007

Status & tagging log