r28455 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28454‎ | r28455 | r28456 >
Date:23:35, 13 December 2007
Author:simetrical
Status:old
Tags:
Comment:
* (bug 10184) Extensions' stylesheets and scripts should be loaded before user-customized ones (like Common.css, Common.js). Tested a bunch of built-in scripts (AJAX watch, preferences) and some enwiki scripts and it all worked perfectly. Thanks to darklama/darkcode for pointing out the ludicrous bug in my previous commit that broke everything.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -71,6 +71,8 @@
7272 <?php print Skin::makeGlobalVariablesScript( $this->data ); ?>
7373
7474 <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath' ) ?>/common/wikibits.js?<?php echo $GLOBALS['wgStyleVersion'] ?>"><!-- wikibits js --></script>
 75+ <!-- Head Scripts -->
 76+<?php $this->html('headscripts') ?>
7577 <?php if($this->data['jsvarurl' ]) { ?>
7678 <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('jsvarurl' ) ?>"><!-- site js --></script>
7779 <?php } ?>
@@ -87,8 +89,6 @@
8890 <script type="<?php $this->text('jsmimetype') ?>"><?php $this->html('userjsprev') ?></script>
8991 <?php }
9092 if($this->data['trackbackhtml']) print $this->data['trackbackhtml']; ?>
91 - <!-- Head Scripts -->
92 -<?php $this->html('headscripts') ?>
9393 </head>
9494 <body <?php if($this->data['body_ondblclick']) { ?>ondblclick="<?php $this->text('body_ondblclick') ?>"<?php } ?>
9595 <?php if($this->data['body_onload' ]) { ?>onload="<?php $this->text('body_onload') ?>"<?php } ?>
Index: trunk/phase3/RELEASE-NOTES
@@ -229,7 +229,7 @@
230230 * (bug 12148) Text highlight wasn't applied to cleanly deleted and added
231231 lines in diff output
232232 * (bug 10166) Fix a PHP warning in Language::getMagic
233 -* Only mark rollback edits as minor if the user can normally mark edits as minor.
 233+* Only mark rollback edits as minor if the user can normally mark edits minor
234234 * Escape page names in the move successful page (e.g. for pages with two
235235 apostrophes).
236236 * (bug 12145) Add localized names of kk-variants
@@ -237,7 +237,10 @@
238238 * Set proper page title for successful file deletion
239239 * (bug 11221) Do not show 'Compare selected versions' button for a history page
240240 with one revision only
241 -* (bug 12267) Set the default date format to Thai solar calender for the Thai language
 241+* (bug 12267) Set the default date format to Thai solar calender for the Thai
 242+ language
 243+* (bug 10184) Extensions' stylesheets and scripts should be loaded before
 244+ user-customized ones (like Common.css, Common.js)
242245
243246 == Parser changes in 1.12 ==
244247

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23541(bug 10184) Site CSS/JS should be included after that added dynamically (e.g....simetrical06:01, 29 June 2007
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007

Status & tagging log