r23120 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23119‎ | r23120 | r23121 >
Date:08:43, 20 June 2007
Author:david
Status:old
Tags:
Comment:
Merged revisions 23103-23119 via svnmerge from
svn+ssh://david@svn.wikimedia.org/svnroot/mediawiki/trunk/phase3

........
r23103 | brion | 2007-06-19 14:13:17 -0700 (Tue, 19 Jun 2007) | 4 lines

* Avoid PHP notice errors when doing HTTP proxy purges for an empty list
* As intended, *skip* the HTTP proxy purges when doing HTCP purges
........
r23106 | raymond | 2007-06-19 15:34:39 -0700 (Tue, 19 Jun 2007) | 1 line

* (bug 10313) "create this page" link in pt-br message file fixed
........
r23110 | robchurch | 2007-06-20 00:02:06 -0700 (Wed, 20 Jun 2007) | 1 line

(bug 9696) Fix handling of brace transformations in "pagemovedtext"
........
r23111 | tstarling | 2007-06-20 00:10:06 -0700 (Wed, 20 Jun 2007) | 1 line

Removed mImageTimestamps, if an extension needs this then it can be set in a ParserAfterTidy hook, using a single DB query.
........
r23112 | tstarling | 2007-06-20 00:13:56 -0700 (Wed, 20 Jun 2007) | 1 line

Removed mImageTimestamps, use the OutputPageParserOutput hook.
........
r23113 | robchurch | 2007-06-20 00:28:45 -0700 (Wed, 20 Jun 2007) | 1 line

(bug 9328) Use "revision-info-current" message in place of "revision-info" when viewing the current revision of a page, if available - ignored if blank or contains "-"
........
r23114 | robchurch | 2007-06-20 00:31:13 -0700 (Wed, 20 Jun 2007) | 1 line

I even had it written on a post-it, and I still forgot to reset this before committing...
........
r23115 | tstarling | 2007-06-20 00:40:42 -0700 (Wed, 20 Jun 2007) | 1 line

fix total breakage of image revert
........
r23116 | robchurch | 2007-06-20 00:46:44 -0700 (Wed, 20 Jun 2007) | 1 line

(bug 8890) Enable wiki text for "license" message
........
Modified paths:
  • /branches/liquidthreads (modified) (history)
  • /branches/liquidthreads/RELEASE-NOTES (modified) (history)
  • /branches/liquidthreads/includes/Article.php (modified) (history)
  • /branches/liquidthreads/includes/ImagePage.php (modified) (history)
  • /branches/liquidthreads/includes/OutputPage.php (modified) (history)
  • /branches/liquidthreads/includes/ParserOutput.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialMovepage.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialUpload.php (modified) (history)
  • /branches/liquidthreads/includes/SquidUpdate.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPt_br.php (modified) (history)
  • /branches/liquidthreads/maintenance/language/messageTypes.inc (modified) (history)
  • /branches/liquidthreads/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: branches/liquidthreads/maintenance/language/messages.inc
@@ -526,6 +526,7 @@
527527 'currentrev',
528528 'revisionasof',
529529 'revision-info',
 530+ 'revision-info-current',
530531 'revision-nav',
531532 'previousrevision',
532533 'nextrevision',
Index: branches/liquidthreads/maintenance/language/messageTypes.inc
@@ -86,6 +86,7 @@
8787 'pubmedurl',
8888 'randompage-url',
8989 'recentchanges-url',
 90+ 'revision-info-current',
9091 'revision-nav',
9192 'rfcurl',
9293 'shareddescriptionfollows',
Index: branches/liquidthreads/includes/ParserOutput.php
@@ -16,7 +16,6 @@
1717 $mTemplates, # 2-D map of NS/DBK to ID for the template references. ID=zero for broken.
1818 $mTemplateIds, # 2-D map of NS/DBK to rev ID for the template references. ID=zero for broken.
1919 $mImages, # DB keys of the images used, in the array key only
20 - $mImageTimestamps, # Map of DBK to rev ID for the template references. ID=zero for broken.
2120 $mExternalLinks, # External link URLs, in the key only
2221 $mHTMLtitle, # Display HTML title
2322 $mSubtitle, # Additional subtitle
@@ -44,7 +43,6 @@
4544 $this->mNoGallery = false;
4645 $this->mHeadItems = array();
4746 $this->mTemplateIds = array();
48 - $this->mImageTimestamps = array();
4947 }
5048
5149 function getText() { return $this->mText; }
@@ -92,19 +90,8 @@
9391 $this->mLinks[$ns][$dbk] = $id;
9492 }
9593
96 - function addImage( $name, $timestamp=NULL ) {
97 - if( isset($this->mImages[$name]) )
98 - return; // No repeated pointless DB calls!
 94+ function addImage( $name ) {
9995 $this->mImages[$name] = 1;
100 - if( is_null($timestamp) ) {
101 - wfProfileIn( __METHOD__ );
102 - $dbr = wfGetDB(DB_SLAVE);
103 - $timestamp = $dbr->selectField('image', 'img_timestamp',
104 - array('img_name' => $name),
105 - __METHOD__ );
106 - }
107 - $timestamp = $timestamp ? $timestamp : null;
108 - $this->mImageTimestamps[$name] = $timestamp; // For versioning
10996 }
11097
11198 function addTemplate( $title, $page_id, $rev_id ) {
Index: branches/liquidthreads/includes/Article.php
@@ -2424,7 +2424,12 @@
24252425 $userlinks = $sk->userLink( $revision->getUser(), $revision->getUserText() )
24262426 . $sk->userToolLinks( $revision->getUser(), $revision->getUserText() );
24272427
2428 - $r = "\n\t\t\t\t<div id=\"mw-revision-info\">" . wfMsg( 'revision-info', $td, $userlinks ) . "</div>\n" .
 2428+ $m = wfMsg( 'revision-info-current' );
 2429+ $infomsg = $current && !wfEmptyMsg( 'revision-info-current', $m ) && $m != '-'
 2430+ ? 'revision-info-current'
 2431+ : 'revision-info';
 2432+
 2433+ $r = "\n\t\t\t\t<div id=\"mw-{$infomsg}\">" . wfMsg( $infomsg, $td, $userlinks ) . "</div>\n" .
24292434 "\n\t\t\t\t<div id=\"mw-revision-nav\">" . wfMsg( 'revision-nav', $prevdiff, $prevlink, $lnk, $curdiff, $nextlink, $nextdiff ) . "</div>\n\t\t\t";
24302435 $wgOut->setSubtitle( $r );
24312436 }
Index: branches/liquidthreads/includes/ImagePage.php
@@ -672,9 +672,6 @@
673673 return;
674674 }
675675
676 - # Record upload and update metadata cache
677 - $this->img->recordUpload( $result, wfMsg( "reverted" ) );
678 -
679676 $wgOut->setPagetitle( wfMsg( 'actioncomplete' ) );
680677 $wgOut->setRobotpolicy( 'noindex,nofollow' );
681678 $wgOut->addHTML( wfMsg( 'imagereverted' ) );
Index: branches/liquidthreads/includes/SpecialUpload.php
@@ -725,7 +725,7 @@
726726 $summary = wfMsgWikiHtml( 'fileuploadsummary' );
727727
728728 $licenses = new Licenses();
729 - $license = wfMsgHtml( 'license' );
 729+ $license = wfMsgExt( 'license', array( 'parseinline' ) );
730730 $nolicense = wfMsgHtml( 'nolicense' );
731731 $licenseshtml = $licenses->getHtml();
732732
Index: branches/liquidthreads/includes/OutputPage.php
@@ -55,7 +55,6 @@
5656 $this->mRevisionId = null;
5757 $this->mNewSectionLink = false;
5858 $this->mTemplateIds = array();
59 - $this->mImageTimestamps = array();
6059 }
6160
6261 public function redirect( $url, $responsecode = '302' ) {
@@ -391,7 +390,6 @@
392391 $this->mHeadItems = array_merge( $this->mHeadItems, (array)$parserOutput->mHeadItems );
393392 // Versioning...
394393 $this->mTemplateIds += (array)$parserOutput->mTemplateIds;
395 - $this->mImageTimestamps += (array)$parserOutput->mImageTimestamps;
396394
397395 wfRunHooks( 'OutputPageParserOutput', array( &$this, $parserOutput ) );
398396 }
Index: branches/liquidthreads/includes/SpecialMovepage.php
@@ -284,12 +284,7 @@
285285 $newText = wfEscapeWikiText( $wgRequest->getVal('newtitle') );
286286 $talkmoved = $wgRequest->getVal('talkmoved');
287287
288 - $text = wfMsg( 'pagemovedtext', $oldText, $newText );
289 -
290 - $allowHTML = $wgRawHtml;
291 - $wgRawHtml = false;
292 - $wgOut->addWikiText( $text );
293 - $wgRawHtml = $allowHTML;
 288+ $wgOut->addHtml( wfMsgExt( 'pagemovedtext', array( 'parse' ), $oldText, $newText ) );
294289
295290 if ( $talkmoved == 1 ) {
296291 $wgOut->addWikiText( wfMsg( 'talkpagemoved' ) );
Index: branches/liquidthreads/includes/SquidUpdate.php
@@ -81,9 +81,14 @@
8282 echo implode("<br />\n", $urlArr) . "<br />\n";
8383 return;
8484 }*/
 85+
 86+ if( empty( $urlArr ) ) {
 87+ return;
 88+ }
8589
86 - if ( $wgHTCPMulticastAddress && $wgHTCPPort )
87 - SquidUpdate::HTCPPurge( $urlArr );
 90+ if ( $wgHTCPMulticastAddress && $wgHTCPPort ) {
 91+ return SquidUpdate::HTCPPurge( $urlArr );
 92+ }
8893
8994 $fname = 'SquidUpdate::purge';
9095 wfProfileIn( $fname );
Index: branches/liquidthreads/languages/messages/MessagesEn.php
@@ -1076,6 +1076,7 @@
10771077 'currentrev' => 'Current revision',
10781078 'revisionasof' => 'Revision as of $1',
10791079 'revision-info' => 'Revision as of $1 by $2',
 1080+'revision-info-current' => '-',
10801081 'revision-nav' => '($1) $2 | $3 ($4) | $5 ($6)', # don't translate or duplicate this message to other languages
10811082 'previousrevision' => '←Older revision',
10821083 'nextrevision' => 'Newer revision→',
Index: branches/liquidthreads/languages/messages/MessagesPt_br.php
@@ -345,7 +345,7 @@
346346 Por favor realize ouro pedido de busca.',
347347 'matchtotals' => 'A pesquisa "$1" resultou $2 títulos de artigos
348348 e $3 artigos com o texto procurado.',
349 -'noexactmatch' => 'Nenhum artigo com um título exatamente igual a este foi encontrado, tentando na pesquisa completa por texto.',
 349+'noexactmatch' => "'''Não existe uma página com o título \"\$1\".''' Você pode [[:\$1|criar tal página]].",
350350 'titlematches' => 'Resultados nos títulos dos artigos',
351351 'notitlematches' => 'Sem resultados nos títulos dos artigos',
352352 'textmatches' => 'Resultados nos textos dos artigos',
Index: branches/liquidthreads/RELEASE-NOTES
@@ -89,6 +89,9 @@
9090 * Kurdish interface latin/arabic writing system with transliteration
9191 * Support wiki text in all query page headers
9292 * Add 'Orphanedpages' as an alias to Special:Lonelypages
 93+* (bug 9328) Use "revision-info-current" message in place of "revision-info"
 94+ when viewing the current revision of a page, if available
 95+* (bug 8890) Enable wiki text for "license" message
9396
9497 == Bugfixes since 1.10 ==
9598
@@ -179,8 +182,10 @@
180183 * Escape the output of magic variables that return page name or part of it
181184 * (bug 10309) Initialise parser state properly in extractSections(), fixes
182185 some cases where section edits broke because tags were improperly stripped
 186+* Avoid PHP notice errors when doing HTTP proxy purges for an empty list
 187+* As intended, *skip* the HTTP proxy purges when doing HTCP purges
 188+* (bug 9696) Fix handling of brace transformations in "pagemovedtext"
183189
184 -
185190 == API changes since 1.10 ==
186191
187192 (For ongoing development discussion, see http://www.mediawiki.org/wiki/API)
Property changes on: branches/liquidthreads
___________________________________________________________________
Modified: svnmerge-integrated
188193 - /trunk/phase3:1-23102
189194 + /trunk/phase3:1-23119

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23103* Avoid PHP notice errors when doing HTTP proxy purges for an empty list...brion21:13, 19 June 2007
r23106* (bug 10313) "create this page" link in pt-br message file fixedraymond22:34, 19 June 2007
r23110(bug 9696) Fix handling of brace transformations in "pagemovedtext"robchurch07:02, 20 June 2007
r23111Removed mImageTimestamps, if an extension needs this then it can be set in a ...tstarling07:10, 20 June 2007
r23112Removed mImageTimestamps, use the OutputPageParserOutput hook.tstarling07:13, 20 June 2007
r23113(bug 9328) Use "revision-info-current" message in place of "revision-info" wh...robchurch07:28, 20 June 2007
r23114I even had it written on a post-it, and I still forgot to reset this before c...robchurch07:31, 20 June 2007
r23115fix total breakage of image reverttstarling07:40, 20 June 2007
r23116(bug 8890) Enable wiki text for "license" messagerobchurch07:46, 20 June 2007

Status & tagging log