r23103 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23102‎ | r23103 | r23104 >
Date:21:13, 19 June 2007
Author:brion
Status:old
Tags:
Comment:
* Avoid PHP notice errors when doing HTTP proxy purges for an empty list
* As intended, *skip* the HTTP proxy purges when doing HTCP purges
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SquidUpdate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SquidUpdate.php
@@ -81,9 +81,14 @@
8282 echo implode("<br />\n", $urlArr) . "<br />\n";
8383 return;
8484 }*/
 85+
 86+ if( empty( $urlArr ) ) {
 87+ return;
 88+ }
8589
86 - if ( $wgHTCPMulticastAddress && $wgHTCPPort )
87 - SquidUpdate::HTCPPurge( $urlArr );
 90+ if ( $wgHTCPMulticastAddress && $wgHTCPPort ) {
 91+ return SquidUpdate::HTCPPurge( $urlArr );
 92+ }
8893
8994 $fname = 'SquidUpdate::purge';
9095 wfProfileIn( $fname );
Index: trunk/phase3/RELEASE-NOTES
@@ -179,6 +179,8 @@
180180 * Escape the output of magic variables that return page name or part of it
181181 * (bug 10309) Initialise parser state properly in extractSections(), fixes
182182 some cases where section edits broke because tags were improperly stripped
 183+* Avoid PHP notice errors when doing HTTP proxy purges for an empty list
 184+* As intended, *skip* the HTTP proxy purges when doing HTCP purges
183185
184186
185187 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r23120Merged revisions 23103-23119 via svnmerge from...david08:43, 20 June 2007

Status & tagging log