r22859 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22858‎ | r22859 | r22860 >
Date:04:16, 9 June 2007
Author:amidaniel
Status:old
Tags:
Comment:
Remove dismiss from deletion log. This simply doesn't make sense to me, nor does it to those I've discussed it with. If you don't want the recreate warning displayed, it's in a div wrapper and can be hidden through css. We don't need a dismiss link on every system message to hide the message permanently; it only makes sense on things like Sitenotice, where users want to hide the current message, having read it, but not necessarily the next.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -2057,7 +2057,6 @@
20582058 );
20592059 if( $reader->hasRows() ) {
20602060 $out->addHtml( '<div id="mw-recreate-deleted-warn">' );
2061 - $out->addHtml( $this->buildWarningDismisser() );
20622061 $out->addWikiText( wfMsg( 'recreate-deleted-warn' ) );
20632062 $viewer = new LogViewer( $reader );
20642063 $viewer->showList( $out );
@@ -2065,22 +2064,6 @@
20662065 }
20672066 }
20682067
2069 - /**
2070 - * Builds a JavaScript fragment that injects a link to dismiss the
2071 - * "recreating deleted" warning
2072 - *
2073 - * @return string
2074 - */
2075 - private function buildWarningDismisser() {
2076 - global $wgJsMimeType;
2077 - return '<script type="' . $wgJsMimeType . '">/*<![CDATA[*/'
2078 - . 'document.write( \'<div class="mw-recreate-deleted-control">'
2079 - . '<a href="javascript:dismissRecreateWarning();">'
2080 - . Xml::escapeJsString( wfMsg( 'recreate-deleted-dismiss' ) )
2081 - . '</a></div>\' );'
2082 - . '/*]]>*/</script>';
2083 - }
2084 -
20852068 }
20862069
20872070 ?>

Follow-up revisions

RevisionCommit summaryAuthorDate
r22878Merged revisions 22856-22877 via svnmerge from...david00:10, 10 June 2007
r22885More cleanup from r22859robchurch15:29, 10 June 2007
r22919Merged revisions 22878-22918 via svnmerge from...david00:00, 12 June 2007

Status & tagging log