r20164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r20163‎ | r20164 | r20165 >
Date:13:25, 6 March 2007
Author:raymond
Status:old
Tags:
Comment:
* (bug 9009) Add username entry field to Special:Contributions
based on a patch of Sui Min
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
——@@ -1185,6 +1185,9 @@
11861186 'sp-contributions-older',
11871187 'sp-contributions-newbies-sub',
11881188 'sp-contributions-blocklog',
 1189+ 'sp-contributions-search',
 1190+ 'sp-contributions-username',
 1191+ 'sp-contributions-submit',
11891192 ),
11901193 'newimages-showfrom' => array(
11911194 'sp-newimages-showfrom',
Index: trunk/phase3/includes/SpecialContributions.php
——@@ -199,13 +199,13 @@
200200
201201 $target = isset( $par ) ? $par : $wgRequest->getVal( 'target' );
202202 if ( !strlen( $target ) ) {
203 - $wgOut->showErrorPage( 'notargettitle', 'notargettext' );
 203+ $wgOut->addHTML( contributionsForm( '' ) );
204204 return;
205205 }
206206
207207 $nt = Title::newFromURL( $target );
208208 if ( !$nt ) {
209 - $wgOut->showErrorPage( 'notargettitle', 'notargettext' );
 209+ $wgOut->addHTML( contributionsForm( '' ) );
210210 return;
211211 }
212212
——@@ -379,23 +379,20 @@
380380
381381 $options['title'] = $wgTitle->getPrefixedText();
382382
383 - $f = "<form method='get' action=\"$wgScript\">\n";
 383+ $f = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) );
 384+
384385 foreach ( $options as $name => $value ) {
385386 if( $name === 'namespace') continue;
386 - $f .= "\t" . wfElement( 'input', array(
387 - 'name' => $name,
388 - 'type' => 'hidden',
389 - 'value' => $value ) ) . "\n";
 387+ $f .= "\t" . Xml::hidden( $name, $value ) . "\n";
390388 }
391389
392 - $f .= '<p>' . wfMsgHtml( 'namespace' ) . ' ' .
393 - HTMLnamespaceselector( $options['namespace'], '' ) .
394 - wfElement( 'input', array(
395 - 'type' => 'submit',
396 - 'value' => wfMsg( 'allpagessubmit' ) )
397 - ) .
398 - "</p></form>\n";
399 -
 390+ $f .= '<fieldset>' .
 391+ Xml::element( 'legend', array(), wfMsg( 'sp-contributions-search' ) ) .
 392+ Xml::inputLabel( wfMsg( 'sp-contributions-username' ), 'target', 'target', 20 , $options['target']) . ' ' .
 393+ wfMsgHtml( 'namespace' ) . ' ' .
 394+ Xml::namespaceSelector( $options['namespace'], '' ) .
 395+ Xml::submitButton( wfMsg( 'ipblocklist-submit' ) ) .
 396+ '</fieldset></form>\n';
400397 return $f;
401398 }
402399
Index: trunk/phase3/includes/SpecialPage.php
——@@ -112,7 +112,7 @@
113113 'Prefixindex' => array( 'IncludableSpecialPage', 'Prefixindex' ) ,
114114 'Ipblocklist' => array( 'SpecialPage', 'Ipblocklist' ),
115115 'Specialpages' => array( 'UnlistedSpecialPage', 'Specialpages' ),
116 - 'Contributions' => array( 'UnlistedSpecialPage', 'Contributions' ),
 116+ 'Contributions' => array( 'SpecialPage', 'Contributions' ),
117117 'Emailuser' => array( 'UnlistedSpecialPage', 'Emailuser' ),
118118 'Whatlinkshere' => array( 'UnlistedSpecialPage', 'Whatlinkshere' ),
119119 'Recentchangeslinked' => array( 'UnlistedSpecialPage', 'Recentchangeslinked' ),
Index: trunk/phase3/languages/messages/MessagesEn.php
——@@ -1844,12 +1844,15 @@
18451845 'uctop' => ' (top)' ,
18461846 'newbies' => 'newbies',
18471847
1848 -'sp-contributions-newest' => 'Newest',
1849 -'sp-contributions-oldest' => 'Oldest',
1850 -'sp-contributions-newer' => 'Newer $1',
1851 -'sp-contributions-older' => 'Older $1',
 1848+'sp-contributions-newest' => 'Newest',
 1849+'sp-contributions-oldest' => 'Oldest',
 1850+'sp-contributions-newer' => 'Newer $1',
 1851+'sp-contributions-older' => 'Older $1',
18521852 'sp-contributions-newbies-sub' => 'For newbies',
18531853 'sp-contributions-blocklog' => 'Block log',
 1854+'sp-contributions-search' => 'Search for contributions',
 1855+'sp-contributions-username' => 'IP Address or username:',
 1856+'sp-contributions-submit' => 'Search',
18541857
18551858 'sp-newimages-showfrom' => 'Show new images starting from $1',
18561859
Index: trunk/phase3/languages/messages/MessagesDe.php
——@@ -1408,7 +1408,7 @@
14091409 'contributions' => 'Benutzerbeiträge',
14101410 'mycontris' => 'Eigene Beiträge',
14111411 'contribsub' => 'Für $1',
1412 -'nocontribs' => 'Es wurden keine Änderungen für diese Kriterien gefunden.',
 1412+'nocontribs' => 'Es wurden keine Benutzerbeiträge mit diesen Kriterien gefunden.',
14131413 'ucnote' => 'Dies sind die letzten <b>$1</b> Beiträge des Benutzers in den letzten <b>$2</b> Tagen.',
14141414 'uclinks' => 'Zeige die letzten $1 Beiträge; zeige die letzten $2 Tage.',
14151415 'uctop' => ' (aktuell)',
——@@ -1420,6 +1420,9 @@
14211421 'sp-contributions-older' => 'Ältere $1',
14221422 'sp-contributions-newbies-sub' => 'Für Neulinge',
14231423 'sp-contributions-blocklog' => 'Sperrlogbuch',
 1424+'sp-contributions-search' => 'Suche nach Benutzerbeiträgen',
 1425+'sp-contributions-username' => 'IP-Adresse oder Benutzername:',
 1426+'sp-contributions-submit' => 'Suche',
14241427
14251428 'sp-newimages-showfrom' => 'Zeige neue Dateien ab $1',
14261429
Index: trunk/phase3/RELEASE-NOTES
——@@ -248,8 +248,9 @@
249249 * (bug 9155) Allow footer info to wrap in Monobook
250250 * (bug 8847) Strip spurious #fragments from request URI to fix redirect
251251 loops on some server configurations
 252+* (bug 9118) Show deletion log on confirmdelete
 253+* (bug 9009) Add username entry field to Special:Contributions
252254
253 -
254255 == Languages updated ==
255256
256257 * Arabic (ar)

Follow-up revisions

RevisionCommit summaryAuthorDate
r20177ooops for r20164. Thanks to Nikerabbitraymond15:33, 6 March 2007
r21395reapply relevant parts of r20164, 20177, 20226...raymond21:18, 19 April 2007