r19935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19934‎ | r19935 | r19936 >
Date:01:24, 15 February 2007
Author:daniel
Status:old
Tags:
Comment:
Bug 8824: check read permission when exporting
Modified paths:
  • /trunk/phase3/includes/SpecialExport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialExport.php
@@ -104,7 +104,13 @@
105105 }
106106 }
107107 }*/
108 - $exporter->pageByName( $page );
 108+
 109+ #Bug 8824: Only export pages the user can read
 110+ $title = Title::newFromText( $page );
 111+ if( is_null( $title ) ) continue; #TODO: perhaps output an <error> tag or something.
 112+ if( !$title->userCan( 'read' ) ) continue; #TODO: perhaps output an <error> tag or something.
 113+
 114+ $exporter->pageByTitle( $title );
109115 }
110116
111117 $exporter->closeStream();

Sign-offs

UserFlagDate
PartTimeGnomeinspected23:08, 22 April 2013 (struck 23:08, 22 April 2013)

Follow-up revisions

RevisionCommit summaryAuthorDate
r112103address bug r19935...jdlrobson13:09, 22 February 2012