r112103 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112102‎ | r112103 | r112104 >
Date:13:09, 22 February 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
address bug r19935

applied slightly modified version of a9984 from ashwini
use click handler rather than focus for this patch to work
in Chrome
Modified paths:
  • /trunk/extensions/MobileFrontend/javascripts/application.js (modified) (history)
  • /trunk/extensions/MobileFrontend/javascripts/beta_application.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/beta_application.js
@@ -25,10 +25,14 @@
2626 document.getElementById( 'zero-rated-banner-red' );
2727
2828 function initClearSearchLink() {
 29+ function onFocusHandler() {
 30+ search.select();
 31+ }
2932 clearSearch.setAttribute( 'title', 'Clear' );
3033 clearSearch.addEventListener( 'mousedown', clearSearchBox, true );
3134 search.addEventListener( 'keyup', handleClearSearchLink, false );
3235 search.addEventListener( 'keydown', handleDefaultText, false );
 36+ search.addEventListener( 'click', onFocusHandler, true );
3337 }
3438
3539 function navigateToLanguageSelection() {
Index: trunk/extensions/MobileFrontend/javascripts/application.js
@@ -22,9 +22,13 @@
2323 languageSelection = document.getElementById( 'languageselection' );
2424
2525 function initClearSearchLink() {
 26+ function onFocusHandler() {
 27+ search.select();
 28+ }
2629 clearSearch.setAttribute( 'title', 'Clear' );
2730 clearSearch.addEventListener( 'mousedown', clearSearchBox, true );
2831 search.addEventListener( 'keyup', handleClearSearchLink, false );
 32+ search.addEventListener( 'click', onFocusHandler, true );
2933 }
3034
3135 function navigateToLanguageSelection() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r19935Bug 8824: check read permission when exportingdaniel01:24, 15 February 2007

Status & tagging log