r19549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19548‎ | r19549 | r19550 >
Date:12:43, 21 January 2007
Author:werdna
Status:old
Tags:
Comment:
Ignore cascading protection for user CSS/JS subpages, as it's obvious that they were placed in user subpages to circumvent needing to protect them. This fixes at least one bot on enwiki
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1148,7 +1148,7 @@
11491149 return false;
11501150 }
11511151
1152 - if ( $doExpensiveQueries && $this->isCascadeProtected() ) {
 1152+ if ( $doExpensiveQueries && $this->isCascadeProtected() && !$this->isCssJsSubpage() ) {
11531153 # We /could/ use the protection level on the source page, but it's fairly ugly
11541154 # as we have to establish a precedence hierarchy for pages included by multiple
11551155 # cascade-protected pages. So just restrict it to people with 'protect' permission,