r19550 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19549‎ | r19550 | r19551 >
Date:13:47, 21 January 2007
Author:robchurch
Status:old
Tags:
Comment:
Reorder conditions from Werdna's previous commit; shortcut if not a user CSS/JS subpage to avoid the expensive queries
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1148,7 +1148,7 @@
11491149 return false;
11501150 }
11511151
1152 - if ( $doExpensiveQueries && $this->isCascadeProtected() && !$this->isCssJsSubpage() ) {
 1152+ if ( $doExpensiveQueries && !$this->isCssJsSubpage() && $this->isCascadeProtected() ) {
11531153 # We /could/ use the protection level on the source page, but it's fairly ugly
11541154 # as we have to establish a precedence hierarchy for pages included by multiple
11551155 # cascade-protected pages. So just restrict it to people with 'protect' permission,