r17248 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17247‎ | r17248 | r17249 >
Date:12:07, 25 October 2006
Author:brion
Status:old
Tags:
Comment:
* (bug 7684) Obey watchcreated preference for Special:Upload watch checkbox
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUpload.php
@@ -717,7 +717,9 @@
718718
719719 $encDestFile = htmlspecialchars( $this->mDestFile );
720720
721 - $watchChecked = $wgUser->getOption( 'watchdefault' )
 721+ $watchChecked =
 722+ ( $wgUser->getOption( 'watchdefault' ) ||
 723+ ( $wgUser->getOption( 'watchcreations' ) && $this->mDestFile == '' ) )
722724 ? 'checked="checked"'
723725 : '';
724726
Index: trunk/phase3/RELEASE-NOTES
@@ -87,6 +87,7 @@
8888 * (bug 6977) Remove 404 link for autogenerated database documentation.
8989 * (bug 7369) Allow "Show Changes" without requiring edit token.
9090 * (bug 7687) Fix movetalk box checks itself when confirming a delete and move.
 91+* (bug 7684) Obey watchcreated preference for Special:Upload watch checkbox
9192
9293
9394 == Languages updated ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r33330Revert strange dest check from r17248 (bug 13725)aaron06:23, 15 April 2008