r33330 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33329‎ | r33330 | r33331 >
Date:06:23, 15 April 2008
Author:aaron
Status:old
Tags:
Comment:
Revert strange dest check from r17248 (bug 13725)
Modified paths:
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUpload.php
@@ -1017,8 +1017,7 @@
10181018 $encDestName = htmlspecialchars( $this->mDesiredDestName );
10191019
10201020 $watchChecked =
1021 - ( $wgUser->getOption( 'watchdefault' ) ||
1022 - ( $wgUser->getOption( 'watchcreations' ) && $this->mDesiredDestName == '' ) )
 1021+ ( $wgUser->getOption( 'watchdefault' ) || $wgUser->getOption( 'watchcreations' ) )
10231022 ? 'checked="checked"'
10241023 : '';
10251024 $warningChecked = $this->mIgnoreWarning ? 'checked' : '';

Follow-up revisions

RevisionCommit summaryAuthorDate
r33387* (bug 13725) Upload form watch checkbox state set correctly with wpDestFile...brion19:02, 15 April 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r17248* (bug 7684) Obey watchcreated preference for Special:Upload watch checkboxbrion12:07, 25 October 2006

Status & tagging log