r17073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17072‎ | r17073 | r17074 >
Date:05:02, 18 October 2006
Author:simetrical
Status:old
Tags:
Comment:
* Finish fixing bug 3205, and bump up $wgStyleVersion.
* Added $wgStyleVersion to a stylesheet call that brion missed.
* Add informative comment to the top of common_rtl.css to the effect that it is really common to all skins, unlike common.css.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/common/common.css (modified) (history)
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/common/common_rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/common.css
@@ -4,7 +4,7 @@
55 */
66 #footer { clear: both }
77 /* images */
8 -div.floatright { float: right; margin: 0 0 1em 1em; }
 8+div.floatright { float: right; clear: right; margin: 0 0 1em 1em; }
99 div.floatright p { font-style: italic; }
1010 div.floatleft { float: left; margin: 0.3em 0.5em 0.5em 0; }
1111 div.floatleft p { font-style: italic; }
Index: trunk/phase3/skins/common/commonPrint.css
@@ -28,7 +28,8 @@
2929
3030 /* images */
3131 div.floatright {
32 - float: right;
 32+ float: right;
 33+ clear: right;
3334 margin: 0;
3435 position:relative;
3536 border: 0.5em solid White;
@@ -136,7 +137,7 @@
137138
138139 p, .documentDescription {
139140 margin: 1em 0 ! important;
140 - line-height: 1.2em;
 141+ line-height: 1.2em;
141142 }
142143
143144 .tocindent p {
Index: trunk/phase3/skins/common/common_rtl.css
@@ -1,3 +1,6 @@
 2+/* This CSS file is called from absolutely every wiki that's RTL: unlike
 3+ * common.css, it's actually common to all skins. */
 4+
25 /* js pref toc */
36 #preftoc { float: right; }
47 /* workaround for moz bug, displayed bullets on left side */
@@ -17,9 +20,9 @@
1821 float: left;
1922 margin-right: 5px;
2023 }
21 -div.tright {
 24+div.tright, div.floatright {
2225 clear: none;
2326 }
24 -div.tleft {
 27+div.tleft, div.floatleft {
2528 clear: left;
2629 }
\ No newline at end of file
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1030,7 +1030,7 @@
10311031 * to ensure that client-side caches don't keep obsolete copies of global
10321032 * styles.
10331033 */
1034 -$wgStyleVersion = '13';
 1034+$wgStyleVersion = '14';
10351035
10361036 # Server-side caching:
10371037
Index: trunk/phase3/includes/Skin.php
@@ -364,7 +364,7 @@
365365 $sheet = $this->getStylesheet();
366366 $action = $wgRequest->getText('action');
367367 $s = "@import \"$wgStylePath/$sheet?$wgStyleVersion\";\n";
368 - if($wgContLang->isRTL()) $s .= "@import \"$wgStylePath/common/common_rtl.css?1\";\n";
 368+ if($wgContLang->isRTL()) $s .= "@import \"$wgStylePath/common/common_rtl.css?$wgStyleVersion\";\n";
369369
370370 $query = "usemsgcache=yes&action=raw&ctype=text/css&smaxage=$wgSquidMaxage";
371371 $s .= '@import "' . self::makeNSUrl( 'Common.css', $query, NS_MEDIAWIKI ) . "\";\n" .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r16987(bug 3205) Stop right floats from stacking horizontally in non-Monobook skins...simetrical06:56, 13 October 2006