r14427 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14426‎ | r14427 | r14428 >
Date:01:56, 28 May 2006
Author:brion
Status:old
Tags:
Comment:
* Work around glitch with the above in {{int:}}; skip redundant transformations,
allow the including parser to do it.
* Fix {{int:}} to use content language, so it won't break caches and links
tables and randomly include data from the wrong language.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -2574,7 +2574,8 @@
25752575 $mwInt =& MagicWord::get( MAG_INT );
25762576 if ( $mwInt->matchStartAndRemove( $part1 ) ) {
25772577 if ( $this->incrementIncludeCount( 'int:'.$part1 ) ) {
2578 - $text = $linestart . wfMsgReal( $part1, $args, true );
 2578+ $text = $linestart . wfMsgReal( $part1, $args, true,
 2579+ /* ui language */false, /* transform */false );
25792580 $found = true;
25802581 }
25812582 }
Index: trunk/phase3/RELEASE-NOTES
@@ -363,6 +363,10 @@
364364 wfMsg() family (except for wfMsgHtml). This allows things like {{plural:}},
365365 {{urlencode:}}, and {{fullurl:}} to be used in most cases correctly.
366366 The content or UI language will be used accordingly for (forContent)?.
 367+* Work around glitch with the above in {{int:}}; skip redundant transformations,
 368+ allow the including parser to do it.
 369+* Fix {{int:}} to use content language, so it won't break caches and links
 370+ tables and randomly include data from the wrong language.
367371
368372
369373 == Compatibility ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r14431Had to revert the changes in r14424 / r14427 due to massive side-effect break...brion09:31, 28 May 2006

Status & tagging log