r14426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14425‎ | r14426 | r14427 >
Date:00:21, 28 May 2006
Author:brion
Status:old
Tags:
Comment:
Tweak bug 4598 with more sanity checks for cases
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
@@ -829,7 +829,26 @@
830830 </p>
831831 !! end
832832
 833+!! test
 834+External link containing double-single-quotes in text '' (bug 4598 sanity check)
 835+!! input
 836+Some [http://example.com/ pretty ''italics'' and stuff]!
 837+!! result
 838+<p>Some <a href="http://example.com/" class='external text' title="http://example.com/" rel="nofollow">pretty <i>italics</i> and stuff</a>!
 839+</p>
 840+!! end
833841
 842+!! test
 843+External link containing double-single-quotes in text embedded in italics (bug 4598 sanity check)
 844+!! input
 845+''Some [http://example.com/ pretty ''italics'' and stuff]!''
 846+!! result
 847+<p><i>Some </i><a href="http://example.com/" class='external text' title="http://example.com/" rel="nofollow"><i>pretty </i>italics<i> and stuff</i></a><i>!</i>
 848+</p>
 849+!! end
 850+
 851+
 852+
834853 ###
835854 ### Quotes
836855 ###
@@ -1240,13 +1259,22 @@
12411260 !! test
12421261 Link containing double-single-quotes '' in text (bug 4598 sanity check)
12431262 !! input
1244 -[[Link|Lista d''e paise d''o munno]]
 1263+Some [[Link|pretty ''italics'' and stuff]]!
12451264 !! result
1246 -<p><a href="https://www.mediawiki.org/index.php?title=Link&amp;action=edit" class="new" title="Link">Lista d<i>e paise d</i>o munno</a>
 1265+<p>Some <a href="https://www.mediawiki.org/index.php?title=Link&amp;action=edit" class="new" title="Link">pretty <i>italics</i> and stuff</a>!
12471266 </p>
12481267 !! end
12491268
12501269 !! test
 1270+Link containing double-single-quotes '' in text embedded in italics (bug 4598 sanity check)
 1271+!! input
 1272+''Some [[Link|pretty ''italics'' and stuff]]!
 1273+!! result
 1274+<p><i>Some </i><a href="https://www.mediawiki.org/index.php?title=Link&amp;action=edit" class="new" title="Link"><i>pretty </i>italics<i> and stuff</i></a><i>!</i>
 1275+</p>
 1276+!! end
 1277+
 1278+!! test
12511279 Plain link to URL
12521280 !! input
12531281 [[http://www.example.org]]

Follow-up revisions

RevisionCommit summaryAuthorDate
r19801Add a mechanism to parserTests when run in --compare or --record mode, to giv...nickj06:59, 6 February 2007
r27906Fix regressions in r27759 -- pages already marked in link cache at link parsi...brion20:45, 27 November 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r14425Add parser tests for bug 4598 ('' in link title)brion00:02, 28 May 2006

Status & tagging log