r14304 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14303‎ | r14304 | r14305 >
Date:07:37, 20 May 2006
Author:hashar
Status:old
Tags:
Comment:
Fix #6025: SpecialImport.php -> wrong message when no file was selected
Patch by Jimmy Collins <jimmy.collins@web.de>
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialImport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialImport.php
@@ -615,7 +615,7 @@
616616 function newFromUpload( $fieldname = "xmlimport" ) {
617617 $upload =& $_FILES[$fieldname];
618618
619 - if( !isset( $upload ) ) {
 619+ if( !isset( $upload ) || !$upload['name'] ) {
620620 return new WikiErrorMsg( 'importnofile' );
621621 }
622622 if( !empty( $upload['error'] ) ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -300,8 +300,8 @@
301301 * (bug 6012) Update to Indonesian localisation (id)
302302 * (bug 6017) Update list of bookstores in German localisation files
303303 * (bug 5187) Allow programmatically bypassing username validation, for scripts
 304+* (bug 6025) SpecialImport: wrong message when no file selected
304305
305 -
306306 == Compatibility ==
307307
308308 Older PHP 4.2 and 4.1 releases are no longer supported; PHP 4 users must

Follow-up revisions

RevisionCommit summaryAuthorDate
r14305Backport from trunk r14304:...hashar07:40, 20 May 2006

Status & tagging log