r13845 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13844‎ | r13845 | r13846 >
Date:15:55, 24 April 2006
Author:hashar
Status:old
Tags:
Comment:
properly set socket as non blocking (bug 4940: unitialized local variables)
Modified paths:
  • /trunk/phase3/includes/SquidUpdate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SquidUpdate.php
@@ -143,8 +143,8 @@
144144 /* open the remaining sockets for this server */
145145 list($server, $port) = explode(':', $wgSquidServers[$ss]);
146146 if(!isset($port)) $port = 80;
147 - $sockets[] = @fsockopen($server, $port, $error, $errstr, 2);
148 - @stream_set_blocking($sockets[$s],false);
 147+ $sockets[$so+1] = @fsockopen($server, $port, $error, $errstr, 2);
 148+ @stream_set_blocking($sockets[$so+1],false);
149149 }
150150 $so++;
151151 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r14489(bug 4940) $action uninitialisedrobchurch01:08, 31 May 2006

Status & tagging log