r14489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14488‎ | r14489 | r14490 >
Date:01:08, 31 May 2006
Author:robchurch
Status:old
Tags:
Comment:
(bug 4940) $action uninitialised
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -330,7 +330,6 @@
331331
332332 /**
333333 * Some styles that are set by user through the user settings interface.
334 - * @todo undefined variables (bug #4940)
335334 */
336335 function doGetUserStyles() {
337336 global $wgUser, $wgUser, $wgRequest, $wgTitle, $wgAllowUserCss;
@@ -338,8 +337,7 @@
339338 $s = '';
340339
341340 if( $wgAllowUserCss && $wgUser->isLoggedIn() ) { # logged in
342 - # FIXME: $action undefined, bug #4940
343 - if($wgTitle->isCssSubpage() && $this->userCanPreview( $action ) ) {
 341+ if($wgTitle->isCssSubpage() && $this->userCanPreview( $wgRequest->getText( 'action' ) ) ) {
344342 $s .= $wgRequest->getText('wpTextbox1');
345343 } else {
346344 $userpage = $wgUser->getUserPage();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r13845properly set socket as non blocking (bug 4940: unitialized local variables)hashar15:55, 24 April 2006

Status & tagging log