r13844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13843‎ | r13844 | r13845 >
Date:15:30, 24 April 2006
Author:robchurch
Status:old
Tags:
Comment:
Treat "allmessagesnotsupporteddb" as wikitext when echoing; change default text
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialAllmessages.php (modified) (history)
  • /trunk/phase3/languages/Messages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialAllmessages.php
@@ -12,8 +12,9 @@
1313 global $wgOut, $wgAllMessagesEn, $wgRequest, $wgMessageCache, $wgTitle;
1414 global $wgUseDatabaseMessages;
1515
16 - if(!$wgUseDatabaseMessages) {
17 - $wgOut->addHTML(wfMsg('allmessagesnotsupportedDB'));
 16+ # The page isn't much use if the MediaWiki namespace is not being used
 17+ if( !$wgUseDatabaseMessages ) {
 18+ $wgOut->addWikiText( wfMsg( 'allmessagesnotsupportedDB' ) );
1819 return;
1920 }
2021
Index: trunk/phase3/RELEASE-NOTES
@@ -114,6 +114,7 @@
115115 * (bug 5659) Change grammar hacks for Bosnian Wikimedia namespaces.
116116 This sort of special casing should be removed and fixed properly.
117117 * Remove useless whitespace from Special:Brokenredirects header
 118+* Treat "allmessagesnotsupporteddb" as wikitext when echoing; change default text
118119
119120 == Compatibility ==
120121
Index: trunk/phase3/languages/Messages.php
@@ -1441,9 +1441,9 @@
14421442 'allmessagesname' => 'Name',
14431443 'allmessagesdefault' => 'Default text',
14441444 'allmessagescurrent' => 'Current text',
1445 -'allmessagestext' => 'This is a list of system messages available in the MediaWiki: namespace.',
 1445+'allmessagestext' => 'This is a list of system messages available in the MediaWiki namespace.',
14461446 'allmessagesnotsupportedUI' => 'Your current interface language <b>$1</b> is not supported by Special:Allmessages at this site.',
1447 -'allmessagesnotsupportedDB' => 'Special:Allmessages cannot be used because wgUseDatabaseMessages is off.',
 1447+'allmessagesnotsupportedDB' => '\'\'\'Special:Allmessages\'\'\' cannot be used because \'\'\'$wgUseDatabaseMessages\'\'\' is switched off.',
14481448 'allmessagesfilter' => 'Message name filter:',
14491449 'allmessagesmodified' => 'Show only modified',
14501450

Status & tagging log