r1234 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r1233‎ | r1234 | r1235 >
Date:22:54, 13 March 2003
Author:lcrocker
Status:old
Tags:
Comment:
Added name attributes to all form elements to facilitate testing.
Modified paths:
  • /trunk/phpwiki/newcodebase/Article.php (modified) (history)
  • /trunk/phpwiki/newcodebase/Skin.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SkinCologneBlue.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialAsksql.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialBlockip.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialEmailuser.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialImagelist.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialIpblocklist.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialLockdb.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialMovepage.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialPreferences.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialUndelete.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialUnlockdb.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialUpload.php (modified) (history)
  • /trunk/phpwiki/newcodebase/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phpwiki/newcodebase/SpecialAsksql.php
——@@ -36,7 +36,7 @@
3737 "action=submit" );
3838
3939 $wgOut->addHTML( "<p>
40 -<form method=post action=\"{$action}\">
 40+<form name='asksql' method=post action=\"{$action}\">
4141 <table border=0><tr>
4242 <td align=right>{$q}:</td>
4343 <td align=left>
Index: trunk/phpwiki/newcodebase/SpecialUndelete.php
——@@ -68,7 +68,7 @@
6969
7070 $action = wfLocalUrlE( $wgLang->specialPage( "Undelete" ), "action=submit" );
7171 $wgOut->addHTML("<p>
72 -<form method=post action=\"{$action}\">
 72+<form name='undelete' method=post action=\"{$action}\">
7373 <input type=hidden name='target' value=\"{$target}\">
7474 <input type=submit name='restore' value=\"".wfMsg("undeletebtn")."\">
7575 </form>");
——@@ -158,4 +158,4 @@
159159 $wgOut->addWikiText(str_replace("$1", $target, wfMsg("undeletedtext")));
160160 return 0;
161161 }
162 -?>
\ No newline at end of file
 162+?>
Index: trunk/phpwiki/newcodebase/SpecialImagelist.php
——@@ -52,7 +52,8 @@
5353 $action = wfLocalUrlE( $wgLang->specialPage( "Imagelist" ),
5454 "sort=byname&limit={$limit}" );
5555
56 - $wgOut->addHTML( "<form method=post action=\"{$action}\">" .
 56+ $wgOut->addHTML( "<form name='imagesearch' method=post action=\"" .
 57+ "{$action}\">" .
5758 "{$cap}: <input type=text size=8 name='wpIlMatch' value=''> " .
5859 "<input type=submit name='wpIlSubmit' value='{$sub}'></form>" );
5960
Index: trunk/phpwiki/newcodebase/SpecialIpblocklist.php
——@@ -45,7 +45,7 @@
4646 $wgOut->addHTML( "<p><font color='red' size='+1'>{$err}</font>\n" );
4747 }
4848 $wgOut->addHTML( "<p>
49 -<form method=post action=\"{$action}\">
 49+<form name='unblockip' method=post action=\"{$action}\">
5050 <table border=0><tr>
5151 <td align='right'>{$ipa}:</td>
5252 <td align='left'>
Index: trunk/phpwiki/newcodebase/SkinCologneBlue.php
——@@ -201,7 +201,7 @@
202202 function searchForm( $label = "" )
203203 {
204204 global $search;
205 - $s = "<form method=get class='inline' action=\"" .
 205+ $s = "<form name='search' method=get class='inline' action=\"" .
206206 wfLocalUrlE( "" ) . "\">";
207207 if ( "" != $label ) { $s .= "{$label}: "; }
208208
Index: trunk/phpwiki/newcodebase/Article.php
——@@ -1019,7 +1019,7 @@
10201020 $delcom = wfMsg( "deletecomment" );
10211021
10221022 $wgOut->addHTML( "
1023 -<form method=post action=\"{$formaction}\">
 1023+<form name='deleteconfirm' method=post action=\"{$formaction}\">
10241024 <table border=0><tr><td align=right>
10251025 {$delcom}:</td><td align=left>
10261026 <input type=text size=20 name='wpReason' value=\"{$wpReason}\">
Index: trunk/phpwiki/newcodebase/SpecialLockdb.php
——@@ -39,7 +39,7 @@
4040 "action=submit" );
4141
4242 $wgOut->addHTML( "<p>
43 -<form method=post action=\"{$action}\">
 43+<form name='lockdb' method=post action=\"{$action}\">
4444 {$elr}:
4545 <textarea name='wpLockReason' rows=10 cols=60 wrap=virtual>
4646 </textarea>
Index: trunk/phpwiki/newcodebase/SpecialPreferences.php
——@@ -165,7 +165,7 @@
166166 $scc = wfMsg( "contextchars" );
167167 $rcc = wfMsg( "recentchangescount" );
168168
169 - $wgOut->addHTML( "<form action=\"$action\" method=post>
 169+ $wgOut->addHTML( "<form name='preferences' action=\"$action\" method=post>
170170 <table border=\"1\"><tr><td valign=top nowrap><b>$qb:</b><br>\n" );
171171
172172 # Quickbar setting
Index: trunk/phpwiki/newcodebase/SpecialUnlockdb.php
——@@ -35,7 +35,7 @@
3636 "action=submit" );
3737
3838 $wgOut->addHTML( "<p>
39 -<form method=post action=\"{$action}\">
 39+<form name='unlockdb' method=post action=\"{$action}\">
4040 <table border=0><tr>
4141 <td align='right'>
4242 <input type=checkbox name='wpLockConfirm'>
Index: trunk/phpwiki/newcodebase/SpecialUserlogin.php
——@@ -208,7 +208,7 @@
209209 $wpEmail = wfEscapeHTML( $wpEmail );
210210
211211 $wgOut->addHTML( "
212 -<form method=post action=\"{$action}\">
 212+<form name='userlogin' method=post action=\"{$action}\">
213213 <table border=0><tr>
214214 <td align=right>$yn:</td>
215215 <td colspan=2 align=left>
Index: trunk/phpwiki/newcodebase/Skin.php
——@@ -453,7 +453,7 @@
454454 function searchForm()
455455 {
456456 global $search;
457 - $s = "<form class='inline' method=get action=\""
 457+ $s = "<form name='search' class='inline' method=get action=\""
458458 . wfLocalUrl( "" ) . "\">"
459459 . "<input type=text name=\"search\" size=19 value=\""
460460 . htmlspecialchars(substr($search,0,256)) . "\">\n"
——@@ -719,7 +719,7 @@
720720 $sp = wfMsg( "specialpages" );
721721 $spp = $wgLang->specialPage( "Specialpages" );
722722
723 - $s = "<form method=get class='inline' " .
 723+ $s = "<form name='specialpages' method=get class='inline' " .
724724 "action=\"{$wgServer}{$wgRedirectScript}\">\n";
725725 $s .= "<select name='wpDropdown'>\n";
726726 $s .= "<option value=\"{$spp}\">{$sp}</option>\n";
Index: trunk/phpwiki/newcodebase/SpecialBlockip.php
——@@ -39,7 +39,7 @@
4040 $wgOut->addHTML( "<p><font color='red' size='+1'>{$err}</font>\n" );
4141 }
4242 $wgOut->addHTML( "<p>
43 -<form method=post action=\"{$action}\">
 43+<form name='blockip' method=post action=\"{$action}\">
4444 <table border=0><tr>
4545 <td align='right'>{$ipa}:</td>
4646 <td align='left'>
Index: trunk/phpwiki/newcodebase/SpecialUpload.php
——@@ -171,7 +171,8 @@
172172 "action=submit" );
173173
174174 $wgOut->addHTML( "
175 -<form method=post enctype='multipart/form-data' action=\"{$action}\">
 175+<form name='uploadwarning' method=post enctype='multipart/form-data'
 176+action=\"{$action}\">
176177 <input type=hidden name='wpUploadAffirm' value='1'>
177178 <input type=hidden name='wpIgnoreWarning' value='1'>
178179 <input type=hidden name='wpUploadDescription' value=\"{$wpUploadDescription}\">
——@@ -217,7 +218,8 @@
218219
219220 $action = wfLocalUrl( $wgLang->specialPage( "Upload" ) );
220221 $wgOut->addHTML( "
221 -<form method=post enctype='multipart/form-data' action=\"{$action}\">
 222+<form name='upload' method=post enctype='multipart/form-data'
 223+action=\"{$action}\">
222224 <table border=0><tr>
223225 <td align=right>{$fn}:</td><td align=left>
224226 <input tabindex=1 type='file' name='wpUploadFile' value=\"{$wpUploadFile}\" size=40>
Index: trunk/phpwiki/newcodebase/SpecialMovepage.php
——@@ -63,7 +63,7 @@
6464 $wgOut->addHTML( "<p><font color='red' size='+1'>{$err}</font>\n" );
6565 }
6666 $wgOut->addHTML( "<p>
67 -<form method=post action=\"{$action}\">
 67+<form name='movepage' method=post action=\"{$action}\">
6868 <table border=0><tr>
6969 <td align=right>{$ma}:</td>
7070 <td align=left><strong>{$ott}</strong></td>
Index: trunk/phpwiki/newcodebase/SpecialEmailuser.php
——@@ -75,7 +75,7 @@
7676 $wgOut->addHTML( "<p><font color='red' size='+1'>{$err}</font>\n" );
7777 }
7878 $wgOut->addHTML( "<p>
79 -<form method=post action=\"{$action}\">
 79+<form name='emailuser' method=post action=\"{$action}\">
8080 <table border=0><tr>
8181 <td align=right>{$emf}:</td>
8282 <td align=left><strong>{$sender}</strong></td>

Follow-up revisions

RevisionCommit summaryAuthorDate
r40884quick hack to apply 'bug 1234' and 'r1234' link transformations to wikitext c...brion21:54, 15 September 2008
r87898Continue implementation QUnit/TestSwarm integration (bug 28915)...krinkle01:34, 12 May 2011

Status & tagging log