r114719 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114718‎ | r114719 | r114720 >
Date:22:25, 4 April 2012
Author:laner
Status:deferred (Comments)
Tags:
Comment:
Removing these memcache calls for now. It doesn't work properly, and doing it correctly will be a lot of effort.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaUser.php
@@ -27,17 +27,7 @@
2828 */
2929 function fetchUserInfo() {
3030 global $wgAuth, $wgUser;
31 - global $wgMemc;
3231
33 - $key = wfMemcKey( 'ldapauthentication', "userinfo", $this->userDN );
34 - $cacheLength = 3600;
35 - $memcUserInfo = $wgMemc->get( $key );
36 - if ( is_array( $memcUserInfo ) ) {
37 - $this->userInfo = $memcUserInfo;
38 - $this->userDN = $this->userInfo[0]["dn"];
39 - $wgAuth->printDebug( "Fetched userdn from memcache: $this->userDN ", NONSENSITIVE );
40 - return;
41 - }
4232 if ( $this->username ) {
4333 $this->userDN = $wgAuth->getUserDN( strtolower( $this->username ) );
4434 $wgAuth->printDebug( "Fetching userdn using username: $this->userDN ", NONSENSITIVE );
@@ -46,7 +36,6 @@
4737 $wgAuth->printDebug( "Fetching userdn using wiki name: " . $wgUser->getName(), NONSENSITIVE );
4838 }
4939 $this->userInfo = $wgAuth->userInfo;
50 - $wgMemc->set( $key, $this->userInfo, $cacheLength );
5140 }
5241
5342 /**

Comments

#Comment by Siebrand (talk | contribs)   22:34, 4 April 2012

Huh? Shouldn't this have been moved to git already?

#Comment by Ryan lane (talk | contribs)   00:26, 5 April 2012

Not until friday.

Status & tagging log