r114720 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114719‎ | r114720 | r114721 >
Date:22:31, 4 April 2012
Author:raindrift
Status:deferred
Tags:
Comment:
use $.param(), per kaldari's comment.
followup to r114623
Modified paths:
  • /trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js (modified) (history)

Diff [purge]

Index: trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js
@@ -68,11 +68,7 @@
6969 },
7070
7171 url: function() {
72 - var paramString = '';
73 - for ( var key in this.apiParams ) {
74 - paramString += '&' + key + '=' + this.apiParams[key];
75 - }
76 - var url = mw.util.wikiScript( 'api' ) + '?action=pagetriagelist&format=json' + paramString;
 72+ var url = mw.util.wikiScript( 'api' ) + '?action=pagetriagelist&format=json&' + $.param( this.apiParams );
7773 console.log('fetching ' + url);
7874 return url;
7975 },

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114623added stuff to the article collection to allow specifying api parameters...raindrift01:26, 30 March 2012

Status & tagging log