r114689 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114688‎ | r114689 | r114690 >
Date:00:46, 4 April 2012
Author:kaldari
Status:deferred (Comments)
Tags:
Comment:
follow-up to r114687 - actually adding the new css file
Modified paths:
  • /trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js (modified) (history)
  • /trunk/extensions/PageTriage/modules/ext.pageTriage.views/ext.pageTriage.listView.css (added) (history)

Diff [purge]

Index: trunk/extensions/PageTriage/modules/ext.pageTriage.views/ext.pageTriage.listView.css
@@ -0,0 +1,11 @@
 2+/*
 3+ * CSS properties that are useful for the pageTriage list view, but don't fall under one of the more
 4+ * specific views
 5+ */
 6+
 7+#mwe-pt-list-more {
 8+ text-align: center;
 9+ background-color: #E8F2F8;
 10+ margin: 1em 0 0 0;
 11+ padding: 0.5em;
 12+}
Index: trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js
@@ -67,6 +67,7 @@
6868 url: function() {
6969 var paramString = '';
7070 for ( var key in this.apiParams ) {
 71+ console.debug(this.apiParams);
7172 paramString += '&' + key + '=' + this.apiParams[key];
7273 }
7374 var url = mw.util.wikiScript( 'api' ) + '?action=pagetriagelist&format=json' + paramString;

Follow-up revisions

RevisionCommit summaryAuthorDate
r114690follow-up to r114689 - reverting accidental commit of debugging codekaldari00:48, 4 April 2012
r114734follow-up to r114689 - fixing indentationkaldari06:50, 5 April 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114687code for More link at bottom of list - not yet activated by anything thoughkaldari00:12, 4 April 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:16, 4 April 2012

Inconsistent indentation.

#Comment by Kaldari (talk | contribs)   06:51, 5 April 2012

fixed in r114734.

Status & tagging log