r114687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114686‎ | r114687 | r114688 >
Date:00:12, 4 April 2012
Author:kaldari
Status:deferred (Comments)
Tags:
Comment:
code for More link at bottom of list - not yet activated by anything though
Modified paths:
  • /trunk/extensions/PageTriage/PageTriage.i18n.php (modified) (history)
  • /trunk/extensions/PageTriage/PageTriage.php (modified) (history)
  • /trunk/extensions/PageTriage/SpecialPageTriage.php (modified) (history)
  • /trunk/extensions/PageTriage/includes/ArticleMetadata.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PageTriage/SpecialPageTriage.php
@@ -158,6 +158,7 @@
159159 </div>
160160 </script>
161161
 162+ <!-- top nav template -->
162163 <script type="text/template" id="listControlNavTemplate">
163164 <span class="mwe-pt-control-label"><b><%= gM( 'pagetriage-showing' ) %></b> some things</span>
164165 <span class="mwe-pt-control-label-right" id="mwe-pt-control-stats"></span><br/>
@@ -230,6 +231,14 @@
231232 <span class="mwe-pt-control-label-right"><b><%= gM( 'pagetriage-viewing' ) %></b> Sort Controls</span>
232233 </script>
233234
 235+ <!-- load more link template -->
 236+ <script type="text/template" id="listMoreLinkTemplate">
 237+ <div id="mwe-pt-list-more">
 238+ <a href="#" style="display: none;"> <%= gM( 'pagetriage-more' ) %> </a>
 239+ </div>
 240+ </script>
 241+
 242+ <!-- bottom nav template -->
234243 <script type="text/template" id="listStatsNavTemplate">
235244 <div id="mwe-pt-top-triager">
236245 <%= ptrTopTriager %>
Index: trunk/extensions/PageTriage/includes/ArticleMetadata.php
@@ -388,7 +388,7 @@
389389 $metaData[$row->page_id]['user_creation_date'] = wfTimestamp( TS_MW, $user->getRegistration() );
390390 $metaData[$row->page_id]['user_autoconfirmed'] = $user->isAllowed( 'autoconfirmed' ) ? '1' : '0';
391391 $metaData[$row->page_id]['user_bot'] = $user->isAllowed( 'bot' ) ? '1' : '0';
392 - $metaData[$row->page_id]['user_block_status'] = $row->ipb_id ? '1' : '0';
 392+ $metaData[$row->page_id]['user_block_status'] = $row->ipb_id ? '1' : '0';
393393 } else {
394394 $metaData[$row->page_id]['user_id'] = 0;
395395 $metaData[$row->page_id]['user_name'] = $row->rev_user_text;
Index: trunk/extensions/PageTriage/PageTriage.i18n.php
@@ -55,6 +55,7 @@
5656 'pagetriage-stats-top-triagers' => 'Top {{PLURAL:$1|triager|$1 triagers}}: $2',
5757 'pagetriage-filter-ns-article' => 'Article',
5858 'pagetriage-filter-ns-all' => 'All',
 59+ 'pagetriage-more' => 'More',
5960 );
6061
6162 /**
@@ -102,4 +103,5 @@
103104 'pagetriage-stats-top-triagers' => 'Text that shows top triagers, $1 is the total number, $2 shows the detail',
104105 'pagetriage-filter-ns-article' => 'The name of the main article namespace, for the namespace filter select list',
105106 'pagetriage-filter-ns-all' => 'For the namespace filter select list, text indicating that all namespaces will be selected',
 107+ 'pagetriage-more' => 'Text for a link that loads more articles into list',
106108 );
Index: trunk/extensions/PageTriage/PageTriage.php
@@ -198,6 +198,7 @@
199199 'ext.pageTriage.views/ext.pageTriage.listItem.css',
200200 'ext.pageTriage.views/ext.pageTriage.listControlNav.css',
201201 'ext.pageTriage.views/ext.pageTriage.listStatsNav.css'
 202+ 'ext.pageTriage.views/ext.pageTriage.listView.css'
202203 ),
203204 'messages' => array(
204205 'days',
@@ -243,6 +244,7 @@
244245 'days',
245246 'pagetriage-filter-ns-article',
246247 'pagetriage-filter-ns-all',
 248+ 'pagetriage-more',
247249 )
248250 );
249251

Follow-up revisions

RevisionCommit summaryAuthorDate
r114688missing a comma!kaldari00:44, 4 April 2012
r114689follow-up to r114687 - actually adding the new css filekaldari00:46, 4 April 2012

Comments

#Comment by Kaldari (talk | contribs)   00:45, 4 April 2012

forgot a comma, added in r114688.

Status & tagging log