r114442 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r114441‎ \| r114442 \| r114443 >
Date:	06:38, 23 March 2012
Author:	tstarling
Status:	ok (Comments)
Tags:	live
Comment:	Transaction for site_stats update, for bug 35047
Modified paths:	/branches/wmf/1.19wmf1/includes/filerepo/file/LocalFile.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/filerepo/file/LocalFile.php
—	—	@@ -1261,7 +1261,9 @@
1262	1262	if ( $status->ok ) {
1263	1263	// Update site_stats
1264	1264	$site_stats = $dbw->tableName( 'site_stats' );
	1265	+ $dbw->begin();
1265	1266	$dbw->query( "UPDATE $site_stats SET ss_images=ss_images-1", __METHOD__ );
	1267	+ $dbw->commit();
1266	1268	$this->purgeEverything();
1267	1269	}
1268	1270

Comments

#Comment by Aaron Schulz (talk | contribs) 04:48, 24 March 2012

The unlock() call below is now misleading. But this functionality ok.

Status & tagging log

15:56, 22 April 2012 Krinkle (talk | contribs) changed the tags for r114442 [removed: 1.20 added: live]
04:11, 3 April 2012 Aaron Schulz (talk | contribs) changed the tags for r114442 [added: 1.20]
04:48, 24 March 2012 Aaron Schulz (talk | contribs) changed the status of r114442 [removed: new added: ok]