r114234 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r114233‎ | r114234 | r114235 >
Date:06:19, 20 March 2012
Author:tstarling
Status:ok
Tags:
Comment:
(bug 35316) On autocreate, use $this as the "doer" in the newuser log entry, since unlike User::addNewUserLogEntry(), there is no way the action could have been triggered by a different user. Usually $wgUser is set correctly, but there's no need to rely on it here.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
——@@ -3943,7 +3943,7 @@
39443944 return true; // disabled
39453945 }
39463946 $log = new LogPage( 'newusers', false );
3947 - $log->addEntry( 'autocreate', $this->getUserPage(), '', array( $this->getId() ) );
 3947+ $log->addEntry( 'autocreate', $this->getUserPage(), '', array( $this->getId() ), $this );
39483948 return true;
39493949 }
39503950

Follow-up revisions

RevisionCommit summaryAuthorDate
r114235MFT r114234: speculative fix for bug 35316. I will deploy it and see if the p...tstarling06:20, 20 March 2012

Status & tagging log