r114235 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r114234‎ | r114235 | r114236 >
Date:06:20, 20 March 2012
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r114234: speculative fix for bug 35316. I will deploy it and see if the problem goes away.
Modified paths:
  • /branches/wmf/1.19wmf1/includes/User.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/User.php
——@@ -3949,7 +3949,7 @@
39503950 return true; // disabled
39513951 }
39523952 $log = new LogPage( 'newusers', false );
3953 - $log->addEntry( 'autocreate', $this->getUserPage(), '', array( $this->getId() ) );
 3953+ $log->addEntry( 'autocreate', $this->getUserPage(), '', array( $this->getId() ), $this );
39543954 return true;
39553955 }
39563956
Property changes on: branches/wmf/1.19wmf1/includes/User.php
___________________________________________________________________
Added: svn:mergeinfo
39573957 Merged /branches/sqlite/includes/User.php:r58211-58321
39583958 Merged /trunk/phase3/includes/User.php:r111029,111034,111067,111085,111128,111144,111251,111397,111427,111571,111574,111597,111658,111673,111695,111697,111750,111827,111965-111967,112021,112045-112046,112049,112061-112063,112065-112066,112070-112071,112079,112128,112132-112133,112152,112184,112259,112290,112347,112374,112378,112381,112383,112397,112408,112474,112526,112534,112563,112700,112839-112840,112843,112855,112866,112951,112995,113099,113169,113195,113312,113412,113441,114234
39593959 Merged /branches/new-installer/phase3/includes/User.php:r43664-66004
39603960 Merged /branches/wmf-deployment/includes/User.php:r53381
39613961 Merged /branches/JSTesting/includes/User.php:r100352-107913
39623962 Merged /branches/REL1_15/phase3/includes/User.php:r51646
39633963 Merged /branches/wmf/1.18wmf1/includes/User.php:r97508,111667

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114234(bug 35316) On autocreate, use $this as the "doer" in the newuser log entry, ...tstarling06:19, 20 March 2012

Status & tagging log