r114174 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114173‎ | r114174 | r114175 >
Date:20:04, 19 March 2012
Author:catrope
Status:ok
Tags:
Comment:
Fix typo in r113968 that broke the weighting code so no CTA ever appeared
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -671,7 +671,7 @@
672672 // the user has rejected this within 3 days of right now
673673 var display = $.cookie( prefix( 'pitch-' + key ) );
674674 if ( display !== 'hide' && context.options.pitches[key].condition() ) {
675 - var weight = 'weight' in context.options.pitches[key] ? pitches.weight : 1;
 675+ var weight = 'weight' in context.options.pitches[key] ? context.options.pitches[key].weight : 1;
676676 for ( var i = 0; i < weight; i++ ) {
677677 pitches.push( key );
678678 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r1141761.19wmf1: MFT r114174catrope20:06, 19 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113968Fix weighting for pitches in AFTv4, has apparently been broken since its intr...catrope22:55, 15 March 2012

Status & tagging log