r113968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113967‎ | r113968 | r113969 >
Date:22:55, 15 March 2012
Author:catrope
Status:ok
Tags:
Comment:
Fix weighting for pitches in AFTv4, has apparently been broken since its introduction
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -671,7 +671,7 @@
672672 // the user has rejected this within 3 days of right now
673673 var display = $.cookie( prefix( 'pitch-' + key ) );
674674 if ( display !== 'hide' && context.options.pitches[key].condition() ) {
675 - var weight = 'weight' in pitches ? pitches.weight : 1;
 675+ var weight = 'weight' in context.options.pitches[key] ? pitches.weight : 1;
676676 for ( var i = 0; i < weight; i++ ) {
677677 pitches.push( key );
678678 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r1139691.19wmf1: MFT r113968catrope22:56, 15 March 2012
r114174Fix typo in r113968 that broke the weighting code so no CTA ever appearedcatrope20:04, 19 March 2012

Status & tagging log