r113962 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113961‎ | r113962 | r113963 >
Date:21:34, 15 March 2012
Author:catrope
Status:deferred
Tags:
Comment:
Fix revision ID tracking to track the new revid instead of the old one
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -448,7 +448,8 @@
449449 public static function trackEditSuccess( &$article, &$user, $text,
450450 $summary, $minoredit, $watchthis, $sectionanchor, &$flags,
451451 $revision, &$status, $baseRevId /*, &$redirect */ ) { // $redirect not passed in 1.18wmf1
452 - self::trackEvent( 'edit_success', $article->getTitle(), $baseRevId );
 452+ $revID = $revision instanceof Revision ? $revision->getID() : 0;
 453+ self::trackEvent( 'edit_success', $article->getTitle(), $revID );
453454 return true;
454455 }
455456

Follow-up revisions

RevisionCommit summaryAuthorDate
r1139741.19wmf1: MFT r113962catrope23:17, 15 March 2012

Status & tagging log