r113974 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113973‎ | r113974 | r113975 >
Date:23:17, 15 March 2012
Author:catrope
Status:ok
Tags:
Comment:
1.19wmf1: MFT r113962
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5 (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php (modified) (history)

Diff [purge]

Property changes on: branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php
___________________________________________________________________
Modified: svn:mergeinfo
11 Merged /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php:r113962
Index: branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -442,7 +442,8 @@
443443 public static function trackEditSuccess( &$article, &$user, $text,
444444 $summary, $minoredit, $watchthis, $sectionanchor, &$flags,
445445 $revision, &$status, $baseRevId /*, &$redirect */ ) { // $redirect not passed in 1.18wmf1
446 - self::trackEvent( 'edit_success', $article->getTitle(), $baseRevId );
 446+ $revID = $revision instanceof Revision ? $revision->getID() : 0;
 447+ self::trackEvent( 'edit_success', $article->getTitle(), $revID );
447448 return true;
448449 }
449450
Property changes on: branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5
___________________________________________________________________
Modified: svn:mergeinfo
450451 Merged /trunk/extensions/ArticleFeedbackv5:r113962

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113962Fix revision ID tracking to track the new revid instead of the old onecatrope21:34, 15 March 2012

Status & tagging log