r113870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113869‎ | r113870 | r113871 >
Date:22:50, 14 March 2012
Author:awjrichards
Status:reverted
Tags:
Comment:
Followup r113865, removing 'disable mobile site permanantly' elements from footer template
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.body.php (modified) (history)
  • /trunk/extensions/MobileFrontend/templates/FooterTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.body.php
@@ -1398,7 +1398,7 @@
13991399 $action = $this->getAction();
14001400
14011401
1402 - if ( $action === 'edit' || $action === 'history' ) {
 1402+ if ( $action === 'edit' ){// || $action === 'history' ) {
14031403 return false;
14041404 }
14051405
Index: trunk/extensions/MobileFrontend/templates/FooterTemplate.php
@@ -9,14 +9,12 @@
1010 public function getHTML() {
1111
1212 $regularSite = $this->data['messages']['mobile-frontend-regular-site'];
13 - $permStopRedirect = $this->data['messages']['mobile-frontend-perm-stop-redirect'];
1413 $copyright = $this->data['messages']['mobile-frontend-copyright'];
1514 $disableImages = $this->data['messages']['mobile-frontend-disable-images'];
1615 $enableImages = $this->data['messages']['mobile-frontend-enable-images'];
1716 $leaveFeedback = $this->data['messages']['mobile-frontend-leave-feedback'];
1817
1918 $leaveFeedbackURL = $this->data['leaveFeedbackURL'];
20 - $disableMobileSiteURL = $this->data['disableMobileSiteURL'];
2119 $viewNormalSiteURL = $this->data['viewNormalSiteURL'];
2220
2321 if ( $this->data['disableImages'] == 0 ) {
@@ -39,9 +37,6 @@
4038 <div class='nav' id='footmenu'>
4139 <div class='mwm-notice'>
4240 <a href="{$viewNormalSiteURL}">{$regularSite}</a> | <a href="{$imagesURL}">{$imagesToggle}</a> {$feedbackLink} {$logoutLink}
43 - <div id="perm">
44 - <a href="{$disableMobileSiteURL}">{$permStopRedirect}</a>
45 - </div>
4641 </div>
4742 </div>
4843 <div id='copyright'>{$copyright}</div>

Follow-up revisions

RevisionCommit summaryAuthorDate
r113871Revert r113870, accidentally checked in codeawjrichards22:53, 14 March 2012
r113872Follow up r113870, r113865, checking in only what I meant to the first time! ...awjrichards22:56, 14 March 2012
r113876Followup r113871, finishing revert of r113870awjrichards23:24, 14 March 2012
r114202MFT r113807, r113831, r113832, r113865, r113866, r113870, r113871, r113872, r...awjrichards22:23, 19 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113865* Changing how 'sticky cookies' work as well as how manually switching betwee...awjrichards21:55, 14 March 2012

Status & tagging log