r113869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113868‎ | r113869 | r113870 >
Date:22:34, 14 March 2012
Author:emsmith
Status:ok
Tags:
Comment:
bug 34774 - make sure everything has a href="#" so we get the right pointers on mouseover
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -981,6 +981,7 @@
982982 $link.text( mw.msg( 'articlefeedbackv5-abuse-saved-masked', data['articlefeedbackv5-flag-feedback'].abuse_count ) );
983983 }
984984 $link.attr( 'rel', data['articlefeedbackv5-flag-feedback'].abuse_count );
 985+ $link.attr( 'href', '#' );
985986 if ( data['articlefeedbackv5-flag-feedback'].abusive ) {
986987 $link.addClass( 'abusive' );
987988 } else {
@@ -1019,6 +1020,7 @@
10201021 $link.text( mw.msg( 'articlefeedbackv5-form-abuse-masked', data['articlefeedbackv5-flag-feedback'].abuse_count ) );
10211022 }
10221023 $link.attr( 'rel', data['articlefeedbackv5-flag-feedback'].abuse_count );
 1024+ $link.attr( 'href', '#' );
10231025 if ( data['articlefeedbackv5-flag-feedback'].abusive ) {
10241026 $link.addClass( 'abusive' );
10251027 } else {
Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -387,6 +387,7 @@
388388 $footer_links .= Html::element( 'a', array(
389389 'id' => "articleFeedbackv5-abuse-link-$id",
390390 'class' => $aclass,
 391+ 'href' => '#',
391392 'rel' => $record[0]->af_abuse_count
392393 ), wfMessage( $msg, $wgLang->formatNum( $record[0]->af_abuse_count ) )->text() );
393394 }

Status & tagging log