r113688 MediaWiki - Code Review archive

Offhand that doesn't look excess to me; if $wgPhpCli is in a directory with a space for instance, you need to be quoting that.

I'm kind of assuming the variable would be set to deal with that. If it is escaped, it needs to be done correctly. I wasted some good time trying to use this function and figure out why the shell call kept failing.

The variable should probably not assume that it's pre-escaped; other paths are not.

Why's it failing for you?

Brion is right. What were you doing that was causing failure? Were you using a $wgPhpCli with a space in it that you'd already quoted? :p

Passing '"php" "path/to/script.php"' (all ascii chars, no spaces) to proc_open() results in failure.

Yeesh. '"php" "path/to/script.php"' is a totally legitimate command to run in bash, but I have no idea about other environments (like WIndows). This sounds like a problem (bug?) with proc_open(). Do you see the same behavior with other PHP functions that take $cmd as an argument? I wonder if proc_open() is also escaping $cmd resulting in nasty double escaped-ness.

I was messing around with this some more. shell_exec seems to work fine without or without the quotes. the popen() type functions are more interesting. I tried:

<?php

#$r = popen( '"php" "C:\wamp\www\MW_trunk/maintenance/showStats.php"', 'r' );
#var_dump( stream_get_contents( $r ) );

$pipes = array();
$process = proc_open(
	'"php" "C:\wamp\www\MW_trunk/maintenance/showStats.php"',
	#'php C:\wamp\www\MW_trunk/maintenance/showStats.php',
	array(
		0 => array( 'pipe', 'r' ), // input
		1 => array( 'pipe', 'w' ), // output
		2 => array( 'file', 'NUL', 'a' ) // error
	),
	$pipes // respective outputs
);

fclose( $pipes[0] );
var_dump( stream_get_contents( $pipes[1] ) );

fclose( $pipes[1] );
proc_close($process);

popen seems to work in either case. proc_open() also works without the quotes:

Aaron@AARON-PC-GAME /c/wamp/www/MW_trunk
$ php shelltest.php
string(162) "Total views       :    654
Total edits       : 194712
Number of articles:   4900
Total pages       :  16430
Number of users   :      8
Number of images  :     46
"

However, proc_open() gives an empty response when I have the extra quotes

Aaron@AARON-PC-GAME /c/wamp/www/MW_trunk
$ php shelltest.php
string(0) ""

OK, wtf...If I set the "bypass cmd.exe" flag it works again. See:

$process = proc_open(
	'"php" "C:\wamp\www\MW_trunk/maintenance/showStats.php"',
	#'php C:\wamp\www\MW_trunk/maintenance/showStats.php',
	array(
		0 => array( 'pipe', 'r' ), // input
		1 => array( 'pipe', 'w' ), // output
		2 => array( 'file', 'NUL', 'a' ) // error
	),
	$pipes, // respective outputs
	null,
	null,
	array( 'bypass_shell' => true )
);