r113689 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113688‎ | r113689 | r113690 >
Date:00:05, 13 March 2012
Author:dale
Status:ok
Tags:
Comment:
use updated mw.html.escape api method
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -214,7 +214,7 @@
215215 */
216216 init: function( element ) {
217217 var _this = this;
218 - mw.log('EmbedPlayer: initEmbedPlayer: ' + $(element).width() );
 218+ mw.log('EmbedPlayer: initEmbedPlayer: ' + $(element).attr('id') );
219219
220220 var playerAttributes = mw.getConfig( 'EmbedPlayer.Attributes' );
221221
@@ -1522,7 +1522,7 @@
15231523 iframeUrl = this.getIframeSourceUrl();
15241524
15251525 // Set up embedFrame src path
1526 - var embedCode = '<iframe src="' + mw.escapeQuotesHTML( iframeUrl ) + '" ';
 1526+ var embedCode = '<iframe src="' + mw.html.escape( iframeUrl ) + '" ';
15271527
15281528 // Set width / height of embed object
15291529 embedCode += 'width="' + this.getPlayerWidth() +'" ';

Status & tagging log