r113598 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113597‎ | r113598 | r113599 >
Date:22:58, 11 March 2012
Author:saper
Status:reverted (Comments)
Tags:gerritmigration 
Comment:
Followup to rr113364: Sometimes
Modified paths:
  • /trunk/extensions/Nuke/Nuke_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Nuke/Nuke_body.php
@@ -222,6 +222,7 @@
223223 if ( !is_null( $pattern ) && trim( $pattern ) !== '' ) {
224224 $where[] = 'rc_title LIKE ' . $dbr->addQuotes( $pattern );
225225 }
 226+ $group = implode( ', ', $what );
226227
227228 $result = $dbr->select( 'recentchanges',
228229 $what,
@@ -229,7 +230,7 @@
230231 __METHOD__,
231232 array(
232233 'ORDER BY' => 'rc_timestamp DESC',
233 - 'GROUP BY' => 'rc_namespace, rc_timestamp, rc_title',
 234+ 'GROUP BY' => $group,
234235 'LIMIT' => $limit
235236 )
236237 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r114394Revert r113364, r113598, r113604, r113793, r113795. Unreviewed changes in Nuke....catrope19:25, 21 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113364Fix bug 23600: column "recentchanges.rc_timestamp" should be in GROUP BY...saper13:28, 8 March 2012

Comments

#Comment by Saper (talk | contribs)   23:00, 11 March 2012

Botched commit message, fix one more case of GROUP BY error

Status & tagging log