r113500 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113499‎ | r113500 | r113501 >
Date:19:01, 9 March 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
PHP Fatal error: Call to undefined method DatabasePostgres::getCoreSchea() in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/installer/PostgresUpdater.php on line 309

Ping r113487
Modified paths:
  • /trunk/phase3/includes/installer/PostgresUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/PostgresUpdater.php
——@@ -306,7 +306,7 @@
307307 $res = $this->db->query(
308308 sprintf(
309309 $q,
310 - $this->db->addQuotes( $this->db->getCoreSchea() ),
 310+ $this->db->addQuotes( $this->db->getCoreSchema() ),
311311 $this->db->addQuotes( $idx )
312312 )
313313 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113487Handle PostgreSQL transaction errors and improve schema detection...saper17:24, 9 March 2012
r113498Fix broken unit tests post r113487...reedy18:52, 9 March 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   19:33, 9 March 2012

Maybe the effected code needs some tests.

Status & tagging log