r113499 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113498‎ | r113499 | r113500 >
Date:18:55, 9 March 2012
Author:reedy
Status:ok
Tags:
Comment:
Fix up some documentation weirdness from r113487
Modified paths:
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -791,26 +791,24 @@
792792 return wfTimestamp( TS_POSTGRES, $ts );
793793 }
794794
795 -
796795 /*
797796 * Posted by cc[plus]php[at]c2se[dot]com on 25-Mar-2009 09:12
798797 * to http://www.php.net/manual/en/ref.pgsql.php
799 - *
800 - * Parsing a postgres array can be a tricky problem, he's my
801 - * take on this, it handles multi-dimensional arrays plus
802 - * escaping using a nasty regexp to determine the limits of each
803 - * data-item.
804798 *
 799+ * Parsing a postgres array can be a tricky problem, he's my
 800+ * take on this, it handles multi-dimensional arrays plus
 801+ * escaping using a nasty regexp to determine the limits of each
 802+ * data-item.
 803+ *
805804 * This should really be handled by PHP PostgreSQL module
806805 *
807806 * @since 1.20
808 - * @param text string: postgreql array returned in a text form like {a,b}
809 - * @param output string
810 - * @param limit int
811 - * @param offset int
 807+ * @param $text string: postgreql array returned in a text form like {a,b}
 808+ * @param $output string
 809+ * @param $limit int
 810+ * @param $offset int
812811 * @return string
813812 */
814 -
815813 function pg_array_parse( $text, &$output, $limit = false, $offset = 1 ) {
816814 if( false === $limit ) {
817815 $limit = strlen( $text )-1;
@@ -895,14 +893,14 @@
896894 return explode(",", $row[0]);
897895 }
898896
899 - function setSearchPath( $search_path ) {
900897 /**
901898 * Update search_path, values should already be sanitized
902899 * Values may contain magic keywords like "$user"
903900 * @since 1.20
904901 *
905 - * @param array list of schemas to be searched by default
 902+ * @param $search_path array list of schemas to be searched by default
906903 */
 904+ function setSearchPath( $search_path ) {
907905 $this->query( "SET search_path = " . implode(", ", $search_path) );
908906 }
909907

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113487Handle PostgreSQL transaction errors and improve schema detection...saper17:24, 9 March 2012

Status & tagging log