r114135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114134‎ | r114135 | r114136 >
Date:13:06, 19 March 2012
Author:emsmith
Status:ok
Tags:
Comment:
bug 35035 - hide/show decline oversight link on oversight/unoversight and make sure the hide link toggles on oversight
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -1138,8 +1138,17 @@
11391139 'apiFlagType': 'delete',
11401140 'apiFlagDir': 1,
11411141 'onSuccess': function( id, data ) {
 1142+ // if there is a "decline oversight" just hide it
 1143+ var $link = $( '#articleFeedbackv5-declineoversight-link-' + id ).hide();
11421144
1143 - // First we must possibly show
 1145+ // Oversight is going to hide this as well, do the unhide/hide toggle
 1146+ var $link = $( '#articleFeedbackv5-hide-link-' + id )
 1147+ .attr( 'action', 'show' )
 1148+ .attr( 'id', 'articleFeedbackv5-show-link-' + id )
 1149+ .text( mw.msg( 'articlefeedbackv5-form-unhide' ) )
 1150+ .removeClass( 'articleFeedbackv5-hide-link' )
 1151+ .addClass( 'articleFeedbackv5-show-link' );
 1152+
11441153 var $link = $( '#articleFeedbackv5-oversight-link-' + id )
11451154 .attr( 'action', 'unoversight' )
11461155 .attr( 'id', 'articleFeedbackv5-unoversight-link-' + id )
@@ -1162,6 +1171,9 @@
11631172 'apiFlagType': 'delete',
11641173 'apiFlagDir': -1,
11651174 'onSuccess': function( id, data ) {
 1175+ // if there is a "decline oversight" just show it
 1176+ var $link = $( '#articleFeedbackv5-declineoversight-link-' + id ).show();
 1177+
11661178 var $link = $( '#articleFeedbackv5-unoversight-link-' + id )
11671179 .attr( 'action', 'oversight' )
11681180 .attr( 'id', 'articleFeedbackv5-oversight-link-' + id )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113267bug 35035 - apparently prototype not only doesn't RUN jobs it doesn't even ha...emsmith18:45, 7 March 2012

Status & tagging log