r113071 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113070‎ | r113071 | r113072 >
Date:19:46, 5 March 2012
Author:tparscal
Status:ok
Tags:
Comment:
Further refinements for r112836 and r112853.
* Used thiner borders on the top, right and bottom of diff lines (looks nicer with many short lines of diff)
* Dropped outlines on changed words altogether and use a slightly darker blue background for added words (couldn't make this look nice in all scenarios)
* Added borders to context lines similar to those used on added/removed lines to make them look more consistent (improves their function as context if they look more similar)
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
@@ -29,19 +29,28 @@
3030 white-space: pre-wrap;
3131 }
3232
33 -td.diff-addedline {
34 - border: solid 4px #a3d3ff;
 33+td.diff-addedline,
 34+td.diff-deletedline {
 35+ border-style: solid;
 36+ border-width: 1px 1px 1px 4px;
3537 border-radius: 0.33em;
3638 }
3739
 40+td.diff-addedline {
 41+ border-color: #a3d3ff;
 42+}
 43+
3844 td.diff-deletedline {
39 - border: solid 4px #ffe49c;
40 - border-radius: 0.33em;
 45+ border-color: #ffe49c;
4146 }
4247
4348 td.diff-context {
4449 background: #F2F2F2;
4550 color: #333333;
 51+ border-style: solid;
 52+ border-width: 1px 1px 1px 4px;
 53+ border-color: #e6e6e6;
 54+ border-radius: 0.33em;
4655 }
4756
4857 .diffchange {
@@ -58,22 +67,18 @@
5968 table-layout: fixed;
6069 }
6170
62 -td.diff-addedline .diffchange {
63 - background: #eaf5ff;
64 - padding: 0.125em 0.25em;
65 - border: solid 1px #5698d6;
66 - border-top: none;
67 - border-bottom: none;
 71+td.diff-addedline .diffchange,
 72+td.diff-deletedline .diffchange {
6873 border-radius: 0.33em;
 74+ padding: 0.25em 0;
6975 }
7076
 77+td.diff-addedline .diffchange {
 78+ background: #d8ecff;
 79+}
 80+
7181 td.diff-deletedline .diffchange {
7282 background: #feeec8;
73 - padding: 0.125em 0.25em;
74 - border: solid 1px #e0b141;
75 - border-top: none;
76 - border-bottom: none;
77 - border-radius: 0.33em;
7883 }
7984
8085 table.diff td {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112836Resolves bug #11374 and improves on r94429, r94461, r101147, r105280, r106884...tparscal21:27, 1 March 2012
r112853Improves on r112836 by only using borders on the left and right of the change...tparscal00:07, 2 March 2012

Status & tagging log