r112993 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112992‎ | r112993 | r112994 >
Date:00:08, 5 March 2012
Author:reedy
Status:ok
Tags:
Comment:
Bug 34979 - [Regression] PHP fatal error in SpecialWikiSets.php

Only build a sorted list of wikis if the set object is valid, otherwise use an empty array
Modified paths:
  • /trunk/extensions/CentralAuth/specials/SpecialWikiSets.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/specials/SpecialWikiSets.php
——@@ -131,13 +131,13 @@
132132 } else {
133133 $usage = wfMsgExt( 'centralauth-editset-nouse', 'parse' );
134134 }
 135+ $sortedWikis = $set->getWikisRaw();
 136+ sort( $sortedWikis );
135137 } else {
136138 $usage = '';
 139+ $sortedWikis = array();
137140 }
138141
139 - $sortedWikis = $set->getWikisRaw();
140 - sort( $sortedWikis );
141 -
142142 # Make an array of the opposite list of wikis
143143 # (all databases *excluding* the defined ones)
144144 $restWikis = array();

Follow-up revisions

RevisionCommit summaryAuthorDate
r113035MFT r110933, r111011, r111218, r112751, r112925, r112993reedy14:31, 5 March 2012
r113037MFT r110703, r110933, r111011, r111218, r112520, r112524, r112660, r112687, r...reedy14:59, 5 March 2012

Status & tagging log