r112687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112686‎ | r112687 | r112688 >
Date:14:20, 29 February 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Bug 34795 - commonswiki.globalimagelinks.gil_page_title contains page titles with underscores AND sometimes whitespaces (1.19 Bug?)

Ping r56201 too

Shouldn't be inserting $title->getText() into the database!!!
Modified paths:
  • /trunk/extensions/GlobalUsage/GlobalUsage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalUsage/GlobalUsage_body.php
——@@ -2,6 +2,10 @@
33
44 class GlobalUsage {
55 private $interwiki;
 6+
 7+ /**
 8+ * @var DatabaseBase
 9+ */
610 private $db;
711
812 /**
——@@ -127,7 +131,7 @@
128132 array(
129133 'gil_page_namespace_id' => $title->getNamespace(),
130134 'gil_page_namespace' => $title->getNsText(),
131 - 'gil_page_title' => $title->getText()
 135+ 'gil_page_title' => $title->getDBkey()
132136 ),
133137 array(
134138 'gil_wiki' => $this->interwiki,

Follow-up revisions

RevisionCommit summaryAuthorDate
r112688MFT r112687reedy14:24, 29 February 2012
r112689MFT r112687reedy14:35, 29 February 2012
r113037MFT r110703, r110933, r111011, r111218, r112520, r112524, r112660, r112687, r...reedy14:59, 5 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56201Rewrote this globalusage extension. Still needs a population script and a lot...btongminh18:28, 11 September 2009

Comments

#Comment by Bryan (talk | contribs)   19:53, 29 February 2012

What a stupid mistake of mine.

#Comment by Reedy (talk | contribs)   19:54, 29 February 2012

Haha. Somewhat also the reviewers fault too ;)

4,060,897 rows needed updating

No real damage done

Status & tagging log