r112887 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112886‎ | r112887 | r112888 >
Date:13:18, 2 March 2012
Author:santhosh
Status:resolved (Comments)
Tags:i18nreview 
Comment:
Fix a copy-paste mistake in r112882
Remove a duplicate addModules call. It is already called in showPage method.
Modified paths:
  • /trunk/extensions/Translate/tag/SpecialPageTranslation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/SpecialPageTranslation.php
@@ -71,8 +71,6 @@
7272 return;
7373 }
7474
75 - $wgOut->addModules( 'ext.translate.special.pagetranslation' );
76 -
7775 if ( $action === 'discourage' || $action === 'encourage' ) {
7876 $id = TranslatablePage::getMessageGroupIdFromTitle( $title );
7977 $dbw = wfGetDB( DB_MASTER );
@@ -88,7 +86,7 @@
8987
9088 if ( $action === 'encourage' ) {
9189 $dbw->delete( $table, $row, __METHOD__ );
92 - // @todo Check if page is currently actually discouraged to prevent duplicate log entries.
 90+ // @todo Check if page is currently actually encourageed to prevent duplicate log entries.
9391 $logger->addEntry( 'encourage', $title, null, array( serialize( $params ) ) );
9492 } else {
9593 $index = array( 'tgr_group', 'tgr_lang' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r112902Fix typo in comment updated in r112887.siebrand16:48, 2 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112882* Follow-up r112878: Fix bad copy-paste....siebrand12:30, 2 March 2012

Comments

#Comment by Nikerabbit (talk | contribs)   16:05, 2 March 2012

Has typo :)

Status & tagging log